enable CSC diagonal counting for triu/tril #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies KKT assembly internals so that the function that counts diagonal entries works for either triu/tril form, but the form of the matrix must be explicitly passed.
This function is currently only ever applied to the user-supplied
P
matrix, so should only ever count diagonal terms on a triu matrix. Including this modification anyway since it makes assumptions more explicit, and might also prevent a bug in some future version that allows full matrices to be passed. Also added some unit tests.Related : #143, which this replaces.