Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable CSC diagonal counting for triu/tril #145

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

goulart-paul
Copy link
Member

Modifies KKT assembly internals so that the function that counts diagonal entries works for either triu/tril form, but the form of the matrix must be explicitly passed.

This function is currently only ever applied to the user-supplied P matrix, so should only ever count diagonal terms on a triu matrix. Including this modification anyway since it makes assumptions more explicit, and might also prevent a bug in some future version that allows full matrices to be passed. Also added some unit tests.

Related : #143, which this replaces.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.10%. Comparing base (7036899) to head (3161be3).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/algebra/csc/utils.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #145      +/-   ##
===========================================
- Coverage    88.14%   88.10%   -0.04%     
===========================================
  Files           77       77              
  Lines         6189     6196       +7     
===========================================
+ Hits          5455     5459       +4     
- Misses         734      737       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goulart-paul goulart-paul changed the base branch from main to develop January 6, 2025 18:15
@goulart-paul goulart-paul merged commit 720ca9e into develop Jan 6, 2025
4 of 12 checks passed
goulart-paul added a commit that referenced this pull request Jan 6, 2025
@goulart-paul goulart-paul deleted the pg/issue_117 branch February 2, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant