Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block compress-debug-sections link arg #111

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Conversation

ianks
Copy link
Collaborator

@ianks ianks commented Dec 11, 2022

Started seeing this pop up recently, like here.

I'm assuming this is happening because Ruby is adding this flag because it detects that ld supports it. However, in rake-compiler-dock we use a different ld for cross compilation which does not support the flag.

The benefits of it in Rust extensions are not clear, and it's better to let cargo choose anyway.

For reference, there's a discussion on Ruby issue tracker about the flag and how it can negatively impact there performance of debugging tools, as well.

@ianks ianks changed the title Block compress-debug-sections linker arg Block compress-debug-sections link arg Dec 11, 2022
@ianks ianks merged commit d5882e3 into main Dec 11, 2022
@ianks ianks deleted the no-compress-debug-sections branch December 11, 2022 18:29
@jbourassa
Copy link
Contributor

😞 looks like that didn't work for wasmtime-rb: https://github.com/bytecodealliance/wasmtime-rb/actions/runs/3676458218/jobs/6217134014

@ianks
Copy link
Collaborator Author

ianks commented Dec 13, 2022

This update would be for the rb-sys crate. Can you try with the crate updated?

@jbourassa
Copy link
Contributor

This update would be for the rb-sys crate. Can you try with the crate updated?

The commit for the above build should have the gem and crate on v0.9.48, which has this change -- right?

oxidize-rb/actions/setup-ruby-and-rust@main
[...]
Vendoring rb-sys v0.9.48 (/home/runner/.cargo/registry/src/github.ghproxy.top-1ecc6299db9ec823/rb-sys-0.9.48) to /home/runner/work/wasmtime-rb/wasmtime-rb/tmp/cargo-vendor/rb-sys
Vendoring rb-sys-build v0.9.48 (/home/runner/.cargo/registry/src/github.ghproxy.top-1ecc6299db9ec823/rb-sys-build-0.9.48) to /home/runner/work/wasmtime-rb/wasmtime-rb/tmp/cargo-vendor/rb-sys-build
Vendoring rb-sys-env v0.1.1 (/home/runner/.cargo/registry/src/github.ghproxy.top-1ecc6299db9ec823/rb-sys-env-0.1.1) to /home/runner/work/wasmtime-rb/wasmtime-rb/tmp/cargo-vendor/rb-sys-env
[...]

@ianks
Copy link
Collaborator Author

ianks commented Dec 13, 2022

Ahh. Weird. I’ll take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants