Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store Stepping State or Breakpoint Rules in the context #67

Merged
merged 4 commits into from
Jul 14, 2019

Conversation

oxinabox
Copy link
Owner

I had hoped this would help with #56, for reasons.
It did not.

But I was planning on doing this anyway as at some point I intend to switch over to IRTools.
and IRTools doesn't have the notion coresponding to Cassette's context.

Turns out (as I suspected) this does not have any performance impact.
Infact it gives a 5% speedup (and 200bytes less allocations)

Before:

julia> @btime @run summer($(rand(4000)))
  8.950 ms (36948 allocations: 827.42 KiB)
2005.1816094488515

julia> @btime @run summer($(rand(4000)))
  9.070 ms (36948 allocations: 827.42 KiB)
2003.61408723352

julia> @btime @run summer($(rand(4000)))
  9.019 ms (36948 allocations: 827.42 KiB)
2004.4255763210997

After

julia> @btime @run summer($(rand(4000)))
  8.364 ms (36948 allocations: 827.41 KiB)
2000.0012459445081

julia> @btime @run summer($(rand(4000)))
  8.502 ms (36948 allocations: 827.41 KiB)
2014.4012688708347

julia> @btime @run summer($(rand(4000)))
  8.262 ms (36948 allocations: 827.41 KiB)
1997.3189807056297

@oxinabox oxinabox merged commit 31409f7 into master Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant