NumericInput doesn't respond to continuous mouse down input #2146
Comments
|
yes this feature is not implemented, but it would be sweet! happy to accept a PR. IIRC, one of the DOM key events (down or press) will fire continuously when held so we can just use that. |
|
oh my comment was about holding the keys, sorry. there's no such continuous event for the mouse, so we'd have to implement it manually with a flag and interval timer 😢 |
reiv
added a commit
to reiv/blueprint
that referenced
this issue
Feb 22, 2018
giladgray
pushed a commit
that referenced
this issue
Mar 13, 2018
* [core] support continuous change in numeric input Fixes #2146 * simulate button press using "mousedown" * simulate button press using "mousedown" * Incorporate requested changes * Reduce continuous change interval to 100ms * Use setInterval() for the continuous change handler * Add and use updateDelta() instead of setting this.delta directly * Add and use startContinousChange() and stopContinousChange() * Fix typo * More refactoring * Add a comment about wrapping setInterval() in setTimeout() * updateDelta() computes the delta itself using direction and event * Replace getIncrementDelta() calls with updateDelta() * Remove handleButtonKeyDown() * More refactoring * Remove handleMouseUp() in favor of stopContinuousChange() * Reset delta in stopContinuousChange()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Steps to reproduce
Click the up/down arrow button for a
NumericInputcomponent and hold down the mouse button.Actual behavior
Nothing happens until you release the mouse button.
Expected behavior
The value in the input should change rapidly while the mouse button is held down.
The text was updated successfully, but these errors were encountered: