Refactor build system, remove Gulp #1786

adidahiya · 2017-11-03T21:22:30Z

⚠️ Targeting branch ad/workspaces

Fixes #116.
Fixes #436.
Fixes #1527.
Fixes #780.

Changes proposed:

Replace Gulp build tooling with Lerna & NPM scripts. Each package now has its own list of "scripts" in package.json. There are a few new private packages which help us manage build configuration. The three types of packages are:

libraries: core, datetime, labs, table
- these are our UI libraries that we publish on NPM
applications: landing-app, docs-app
- these require bundling with webpack
- I renamed these from site-landing and site-docs because I feel like "application" much better represents what they are; they're not static web pages
build tooling: webpack-build-scripts, karma-build-scripts, tslint-config
- these new private packages help us:
  - keep clear API boundaries for build configuration
  - isolate groups of dev dependencies
- in the future, we might publish these packages for use in other blueprint repos

A decent amount of cruft was removed in this process:

Removed all usage of the deprecated typings registry in favor of @types packages from NPM.
All projects share tsc configuration using TypeScript's "extends" inheritance feature (it was unsupported in gulp-typescript).

There is a new publishing workflow. I brought over some of our internal monorepo build scripts to handle publishing using Lerna publish commits (generated by lerna publish).

And a few random enhancements:

Faster CI builds with concurrent containers -- we run dist, test, and lint in parallel.

Further improvements to be addressed in future PRs

Fix skipped table unit tests WIP: skipped table tests in build system refactor #1794
Enable no-implicit-dependencies lint rule
Bring documentalist into this repo (it's languishing out there on its own, unloved 😢)
Switch test runner from phantomjs to headless Chrome
UMD bundle externals Webpack externals configuration is incorrect for commonjs / amd environments #1805
import from "sinon" in a consistent way
use node-sass-chokidar (Switch to node-sass-chokidar #1134)
watch variant of generate-docs-data

Remaining tasks

…cripts

adidahiya · 2017-11-07T22:45:39Z

it's beautiful 😂

blueprint-bot · 2017-11-16T12:35:44Z

compile libs in all CI container

Preview: documentation | landing | table
Coverage: core | datetime

blueprint-bot · 2017-11-16T13:17:05Z

fix build artifacts

Preview: documentation | landing | table
Coverage: core | datetime

adidahiya · 2017-11-16T13:18:54Z

almost good to go... missing some assets in the statically built artifacts:

icon font in docs site
svg images (non-inline ones) in landing app

adidahiya · 2017-11-16T14:04:40Z

Gulpfile.js

@@ -98,10 +98,6 @@ const projects = [
            entry: "src/index.tsx",


should delete this file

blueprint-bot · 2017-11-16T14:11:50Z

fix public paths

Preview: documentation | landing | table
Coverage: core | datetime

jrafidi · 2017-11-16T14:07:28Z

packages/core/src/components/card/card.tsx

@@ -58,7 +58,7 @@ const ELEVATION_CLASSES = [
 export class Card extends React.Component<ICardProps, {}> {
    public static displayName = "Blueprint.Card";
    public static defaultProps: ICardProps = {
-        elevation: Elevation.ZERO,


seems wrong?

jrafidi · 2017-11-16T14:14:51Z

packages/labs/test/tsconfig.json

+        "declaration": false,
+        "noEmit": true
+    }
+}


jrafidi · 2017-11-16T14:17:37Z

packages/node-build-scripts/package.json

+  },
+  "author": "Palantir Technologies",
+  "license": "Apache-2.0"
+}


jrafidi · 2017-11-16T14:21:49Z

packages/webpack-build-scripts/webpack.config.base.js

+    {
+        loader: require.resolve("postcss-loader"),
+        options: {
+            config: { path: path.resolve(__dirname, "postcss.config.js") },


where does this __dirname resolve? usage on line 100 implies it resolves in the directory in which webpack is being run, so is postcss not happening?

blueprint-bot · 2017-11-16T14:56:44Z

address CR comments

Preview: documentation | landing | table
Coverage: core | datetime

blueprint-bot · 2017-11-16T15:07:25Z

fix table preview public url

Preview: documentation | landing | table
Coverage: core | datetime

adidahiya · 2017-11-16T15:12:15Z

* Switch to yarn workspaces, upgrade some dev dependencies * [core] fix typescript compilation * Remove require-shim.d.ts files, we now use @types/node * [table] fix typescript compilation * update tsconfig.json files * [docs] fix typescript compilation * [labs] fix typescript compilation * [core] fix some tests * bump to webpack 3! remove localResolve support -- not necessary with hoisting * fix ts-loader errors * clean yarn.lock * massage package.json versions to hoist as much as possible * upgrade site-landing and table preview to webpack 3 * get karma webpacking * karma serves/includes correct files * ⭐ test compile errors now fail the build! * fix core and datetime tests * fix webpack-watch * quick ignore ContextMenu component cuz it's untestable (not exported) * bump range slider test coverage * Fix Table test typings * Comment out broken tests :/ * Refactor build system, remove Gulp (#1786) * Remove Gulpfile.js

adidahiya added 10 commits November 1, 2017 18:40

WIP: refactor build system

032d184

Move examples into packages/site-docs

f4d17a3

Remove tsd typings, clean up tsconfig files

56eb15b

Remove test/imports.ts

8c00a15

Remove core/test/ as a ts project, rely on karma-typescript-preprocessor

bfdd706

Small rename to webpack-build-scripts

85ff622

Split out core tsconfig again

a9d3f60

Import sinon correctly in tests

d7e6f15

Create karma-build-scripts package

838883f

Core tests work!

8fc5a3e

adidahiya added the Status: work in progress label Nov 3, 2017

adidahiya requested a review from giladgray November 3, 2017 21:22

adidahiya added 14 commits November 3, 2017 17:30

minor comment update

e6b992a

Revert some core typings changes

a40d777

Datetime tests work

c55cb35

Merge remote-tracking branch 'origin/master' into ad/refactor-build-s…

cdc4161

…cripts

Resolve popper.js to v1.11.0

641ec97

Labs package builds & tests pass

713e7db

table tests run

0fb5856

Fix table test suite

3e57bca

Update CI scripts

58aec2e

Docs webpack builds successfully

77fecd5

Upgrade popper.js to latest version

4c141b9

Standardize site-landing tsconfig.json

4b315ed

Site-docs web pack dev server works

fe0efed

site-docs webpack dev server kinda works

25e28d5

lint

b241e39

adidahiya changed the title ~~Refactor build system, remove Gulp~~ [WIP] Refactor build system, remove Gulp Nov 8, 2017

Move tslint config to a package; prune root dependencies

f59ec6b

adidahiya changed the title ~~[WIP] Refactor build system, remove Gulp~~ Refactor build system, remove Gulp Nov 16, 2017

adidahiya added 8 commits November 16, 2017 03:12

regen lockfile

1c657d7

remove unused typescript preprocessor

a847b71

loosen type safety on ofType<T> static methods

5f000a3

Fix tslint, run fixer

0f7f994

Fix rename in circle.yml

83c5526

Run root scripts with —parallel flag

e74ab66

Fix compilation

e3abe2a

compile libs in all CI container

89db4a3

fix build artifacts

c93d88d

fix public paths

a5dd443

adidahiya commented Nov 16, 2017

View reviewed changes

Gulpfile.js

@@ -98,10 +98,6 @@ const projects = [

entry: "src/index.tsx",

Copy link

Contributor Author

adidahiya Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should delete this file

revert another card elevation thingy

eb746f0

jrafidi reviewed Nov 16, 2017

View reviewed changes

adidahiya added 3 commits November 16, 2017 14:34

fix table dev preview static site

8f80ee3

better error message for assert-package-layout

9cab0af

address CR comments

ffe8f2f

fix table preview public url

7be8fa2

adidahiya merged commit 83ffd5e into ad/workspaces Nov 16, 2017

adidahiya deleted the ad/refactor-build-scripts branch November 16, 2017 15:13

adidahiya mentioned this pull request Nov 16, 2017

📦 Switch to Yarn workspaces; overhaul build system #1741

Merged

adidahiya mentioned this pull request Dec 19, 2017

Follow-ups from build system refactor #1944

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor build system, remove Gulp #1786

Refactor build system, remove Gulp #1786

adidahiya commented Nov 3, 2017 •

edited

Loading

adidahiya commented Nov 7, 2017

blueprint-bot commented Nov 16, 2017

blueprint-bot commented Nov 16, 2017

adidahiya commented Nov 16, 2017 •

edited

Loading

adidahiya Nov 16, 2017

blueprint-bot commented Nov 16, 2017

jrafidi Nov 16, 2017

jrafidi Nov 16, 2017

jrafidi Nov 16, 2017

jrafidi Nov 16, 2017

blueprint-bot commented Nov 16, 2017

blueprint-bot commented Nov 16, 2017

adidahiya commented Nov 16, 2017

		@@ -98,10 +98,6 @@ const projects = [
		entry: "src/index.tsx",

Refactor build system, remove Gulp #1786

Refactor build system, remove Gulp #1786

Conversation

adidahiya commented Nov 3, 2017 • edited Loading

Changes proposed:

Further improvements to be addressed in future PRs

Remaining tasks

adidahiya commented Nov 7, 2017

blueprint-bot commented Nov 16, 2017

compile libs in all CI container

blueprint-bot commented Nov 16, 2017

fix build artifacts

adidahiya commented Nov 16, 2017 • edited Loading

adidahiya Nov 16, 2017

Choose a reason for hiding this comment

blueprint-bot commented Nov 16, 2017

fix public paths

jrafidi Nov 16, 2017

Choose a reason for hiding this comment

jrafidi Nov 16, 2017

Choose a reason for hiding this comment

jrafidi Nov 16, 2017

Choose a reason for hiding this comment

jrafidi Nov 16, 2017

Choose a reason for hiding this comment

blueprint-bot commented Nov 16, 2017

address CR comments

blueprint-bot commented Nov 16, 2017

fix table preview public url

adidahiya commented Nov 16, 2017

adidahiya commented Nov 3, 2017 •

edited

Loading

adidahiya commented Nov 16, 2017 •

edited

Loading