Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the :through option of authorize to be passed a proc #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow the :through option of authorize to be passed a proc #293

wants to merge 1 commit into from

Conversation

brendon
Copy link
Contributor

@brendon brendon commented Feb 26, 2025 •
edited
Loading

Closes #291

What is the purpose of this pull request?

Allows one to provide a proc to authorize's :through option.

What changes did you make? (overview)

Extended build_authorization_context to cope with a proc being passed in.

Is there anything you'd like reviewers to focus on?

No.

PR checklist:

  • Tests included
  • Documentation updated
  • Changelog entry added

@brendon
Copy link
Contributor Author

brendon commented Feb 26, 2025

There are a few Rails 8.1 deprecations reported. They were a bit confusing so I've left them as is. Unrelated to this PR.

@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 93.789% (+0.02%) from 93.768%
when pulling 9daef6a on brendon:through-proc
into 16992cd on palkan:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing a proc to authorize
1 participant
@brendon