Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Intermittent tradingview crash on setup #11253

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 25, 2025


PR-Codex overview

This PR enhances error handling in the TradingView component by wrapping the widget initialization in a try-catch block, allowing it to gracefully handle any initialization failures.

Detailed summary

  • Added a try-catch block around the TradingViewObj.widget initialization.
  • Introduced error logging with console.error for initialization failures.
  • If an error occurs, the function returns undefined.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 9:10am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 9:10am
blog ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 9:10am
bridge ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 9:10am
games ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 9:10am
gamification ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 9:10am
uikit ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 9:10am
ton ⬜️ Skipped (Inspect) Feb 25, 2025 9:10am

Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: e66106b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@memoyil memoyil force-pushed the feature/fix_intermittent_trading_view_crash_on_setup branch from f54c8c6 to e66106b Compare February 25, 2025 08:50
@vercel vercel bot temporarily deployed to Preview – ton February 25, 2025 08:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant