[internal] Cache native client binary in CI #12355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
commented
Jul 16, 2021
Comment on lines
-54
to
-63
| # We expose a safety valve to skip compilation iff the user already has `native_engine.so`. This | ||
| # can result in using a stale `native_engine.so`, but we trust that the user knows what | ||
| # they're doing. | ||
| if [[ "${SKIP_NATIVE_ENGINE_SO_BOOTSTRAP}" == "true" ]]; then | ||
| if [[ ! -f "${NATIVE_ENGINE_RESOURCE}" || ! -f "${NATIVE_ENGINE_RESOURCE_PYO3}" ]]; then | ||
| die "You requested to override bootstrapping native_engine.so and native_engine_pyo3.so via the env var" \ | ||
| "SKIP_NATIVE_ENGINE_SO_BOOTSTRAP, but the files do not exist at" \ | ||
| "${NATIVE_ENGINE_RESOURCE} and ${NATIVE_ENGINE_BINARY_PYO3}. This is not safe to do." | ||
| fi | ||
| return |
There was a problem hiding this comment.
Unused now that we don't have Travis.
Comment on lines
-72
to
-75
| if [[ ! -f "${NATIVE_ENGINE_RESOURCE}" || ! -f \ | ||
| "${NATIVE_ENGINE_RESOURCE_PYO3}" || ! -f \ | ||
| "${NATIVE_CLIENT_PATH}" || \ | ||
| "${engine_version_calculated}" != "${engine_version_in_metadata}" ]]; then |
There was a problem hiding this comment.
Inverted the conditional for less nesting.
benjyw
approved these changes
Jul 16, 2021
.github/workflows/test-cron.yaml
Outdated
| @@ -132,7 +134,9 @@ jobs: | |||
| uses: actions/upload-artifact@v2 | |||
| with: | |||
| name: native_engine.so.${{ matrix.python-version }}.${{ runner.os }} | |||
There was a problem hiding this comment.
The name is no longer entirely accurate. Maybe should be native_code.${...} (if you change the name on upload you have to change it correspondingly on download).
[ci skip-rust] [ci skip-build-wheels]
Merged
wisechengyi
added a commit
that referenced
this pull request
Jul 17, 2021
### Internal * [internal] Manually fix Black lockfile to handle interpreter constraints ([#12366](#12366)) * Revert "Prefix the entire setup.py chroot. (#12359)" ([#12370](#12370)) * [internal] Cache native client binary in CI ([#12355](#12355)) * Prefix the entire setup.py chroot. ([#12359](#12359)) * [internal] Fix AWS CLI breaking due to Python 2 usage ([#12364](#12364)) * [Internal] Add `git_url()` helper to `docutil.py` ([#12352](#12352)) * [Internal] Refactor how `PythonToolBase` exposes requirements and interpreter constraints ([#12356](#12356)) * [internal] Add experimental per-tool lockfiles with Docformatter as an example ([#12346](#12346)) * Remove Pants's dpeendency on `requests` ([#12348](#12348)) * [internal] Remove `TwoStepPex` abstraction ([#12343](#12343)) * Add psycopg2-binary to default module mapping ([#12339](#12339)) * [internal] Upgrade toolchain pants plugin to 0.13.1 ([#12338](#12338)) * Add an API to coarsen/partition Targets by their cycles ([#12251](#12251)) * Prepare 2.5.1 ([#12329](#12329)) * Bootstrap fewer JVM versions in Coursier/javac tests to hopefully reduce CI flakiness ([#12325](#12325)) * Native client respects `--concurrent`. ([#12324](#12324)) * Add client lib tests. ([#12322](#12322)) * Special case enum option parse failures. ([#12281](#12281))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we end up re-compiling
.pantsin every CI job, including the lint and test jobs.