Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: resolve go_module target into dependent modules #12394

Merged
merged 11 commits into from
Jul 22, 2021
Merged

go: resolve go_module target into dependent modules #12394

merged 11 commits into from
Jul 22, 2021

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Jul 21, 2021 •
edited
Loading

Go plugin updates:

  • Adds a ResolvedGoModule type that represents a go_module with all relevant module and external module metadata hydrated.
  • Adds experimental go-resolve goal that updates go.sum.

Next steps will be to use this support for dependency inference of go_package targets to go_external_module targets.

Tom Dyas added 2 commits July 21, 2021 14:19
basic module resolution
c70ed2b 
[ci skip-rust]

[ci skip-build-wheels]
updates
eeb073d 
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas changed the title go: resolve go_module target into dependent modules [WIP] go: resolve go_module target into dependent modules Jul 21, 2021
@Eric-Arellano

This comment has been minimized.

Sign in to view
Tom Dyas added 3 commits July 21, 2021 15:32
fix integration test setup
4efc385 
[ci skip-rust]

[ci skip-build-wheels]
checkpoint
15c4860 
[ci skip-rust]

[ci skip-build-wheels]
get go-resolve goal working
fa3d90c 
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas changed the title [WIP] go: resolve go_module target into dependent modules go: resolve go_module target into dependent modules Jul 21, 2021
@tdyas tdyas marked this pull request as ready for review July 21, 2021 21:06
Tom Dyas added 2 commits July 21, 2021 17:08
fix lint error
8cb5905 
[ci skip-rust]

[ci skip-build-wheels]
another lint fix
6cacab1 
[ci skip-rust]

[ci skip-build-wheels]
Eric-Arellano
Eric-Arellano reviewed Jul 21, 2021
View reviewed changes
Tom Dyas added 3 commits July 21, 2021 18:18
configure mypy to ignore missing ijson stubs
7d5ade3 
[ci skip-rust]

[ci skip-build-wheels]
TODOs and other review comments
8032b36 
[ci skip-rust]

[ci skip-build-wheels]
use validate_resolved_files for GoModuleSources field
a3e343f 
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas requested a review from Eric-Arellano July 21, 2021 22:36
Eric-Arellano
Eric-Arellano approved these changes Jul 21, 2021
View reviewed changes
remove moot check
366f872 
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas merged commit 1c4f8e1 into pantsbuild:main Jul 22, 2021
@tdyas tdyas deleted the golang_resolve_modules branch July 22, 2021 00:25
@Eric-Arellano Eric-Arellano mentioned this pull request Jul 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@stuhood stuhood Awaiting requested review from stuhood

@jsirois jsirois Awaiting requested review from jsirois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdyas @Eric-Arellano