Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant cache lookup debug logging #12395

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Remove redundant cache lookup debug logging #12395

merged 1 commit into from
Jul 22, 2021

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Jul 21, 2021

The cache lookup workunit (a few lines up) already mutates itself to report the hit, so additionally reporting the hit on the parent workunit is redundant, and looks like:

15:30:10.02 [DEBUG] Completed: Hit: Local cache lookup: Determine Python imports for src/python/pants/engine/internals/mapper_test.py:tests
15:30:10.03 [DEBUG] Completed: Hit local cache: Scheduling: Determine Python imports for src/python/pants/engine/internals/mapper_test.py:tests

@stuhood stuhood requested review from tdyas and Eric-Arellano July 21, 2021 22:38
@stuhood stuhood merged commit 02979ce into pantsbuild:main Jul 22, 2021
@stuhood stuhood deleted the stuhood/remove-stray-workunit-mutation branch July 22, 2021 00:16
@Eric-Arellano Eric-Arellano mentioned this pull request Jul 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@tdyas tdyas Awaiting requested review from tdyas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuhood @Eric-Arellano