fix: js/ts dependency inference with file suffix #22041
Open
+60
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -166,7 +166,7 @@ def _add_extensions(file_imports: frozenset[str], file_extensions: tuple[str, .. | |||
| for file_import in file_imports | |||
| for string in ( | |||
| [file_import] | |||
| if PurePath(file_import).suffix | |||
| if PurePath(file_import).suffix and PurePath(file_import).suffix in file_extensions | |||
There was a problem hiding this comment.
When we had a file like foo.<suffix>.js, foo.<suffix> was being added to the PathGlobs, but that file doesn't exist, the correct would be to fallback to the else statement and use foo.<suffix>.(<file_extensions>), so I'm adding a check to make sure the suffix is what we would expect coming from the parameters (all js/ts extensions depending on each dependency inference).
| rule_runner.write_files( | ||
| { | ||
| "root/project/src/__generated__/BUILD": "javascript_sources()", | ||
| "root/project/src/__generated__/moduleA.generated.js": "", |
There was a problem hiding this comment.
.generated.js is one use case, but any suffix should be handled correctly.
benjyw
reviewed
Mar 6, 2025
src/python/pants/backend/javascript/dependency_inference/rules.py
Outdated
Show resolved
Hide resolved
benjyw
reviewed
Mar 6, 2025
src/python/pants/backend/javascript/dependency_inference/rules.py
Outdated
Show resolved
Hide resolved
|
macos test suite failed with: can we re-run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Its possible that we have a file like
foo.<suffix>.js, but when importing that file on another .js file, dependency inference wasn't working.