chore: add metrics on redundant proof nodes #14969
Merged
+97
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-perf
Rjected
force-pushed
the
dan/add-redundant-proof-nodes-metrics
branch
5 times, most recently
from
f4282b7 to
53725df
Compare
mattsse
reviewed
Mar 11, 2025
| @@ -260,8 +265,10 @@ impl<F: BlindedProviderFactory> SparseStateTrie<F> { | |||
|
|
|||
| // Reveal the remaining proof nodes. | |||
| for (path, bytes) in account_nodes { | |||
| self.metrics.increment_total_account_nodes(); | |||
There was a problem hiding this comment.
I see we can't incr with the len here because this is already an iter
mattsse
added
the
A-observability
shekhirin
approved these changes
Mar 12, 2025
| @@ -521,11 +530,17 @@ impl<F: BlindedProviderFactory> SparseStateTrie<F> { | |||
| /// | |||
| /// If the trie has not been revealed, this function reveals the root node and returns its hash. | |||
| pub fn root(&mut self) -> SparseStateTrieResult<B256> { | |||
| // record revealed node metrics | |||
| self.metrics.record(); | |||
There was a problem hiding this comment.
should be fine to run only at the end of computation, and not on every update_rlp_node_level
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Rjected
force-pushed
the
dan/add-redundant-proof-nodes-metrics
branch
from
53725df to
67b8183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some metrics for checking how many proof nodes were already revealed over the life of a sparse state trie. These are some counters and some histograms, that get recorded when we calculate the root.