feat: Impl TryFrom<Recovered<TxEnvelope for MockTransaction #15005
+109
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Mar 13, 2025
| #[allow(unreachable_patterns)] | ||
| match transaction { | ||
| EthereumTxEnvelope::Legacy(signed_tx) => { | ||
| let tx = signed_tx.tx(); |
There was a problem hiding this comment.
you can use .strip_signature here and then get rid of the additional clones,
I think we should introduce fn into_tx in addition to strip_signature because this is more intuitive, mind submitting this to alloy as well?
| let hash = *transaction.tx_hash(); | ||
| let size = transaction.size(); | ||
|
|
||
| #[allow(unreachable_patterns)] |
There was a problem hiding this comment.
I don't think we need this here or on the TransactionSigned match, i believe this is a leftover from optimism features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15001