Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Provide binary for test service #1128

Closed
bkchr opened this issue Mar 31, 2022 · 3 comments
Closed

Provide binary for test service #1128

bkchr opened this issue Mar 31, 2022 · 3 comments
Assignees

Comments

@bkchr
Copy link
Member

bkchr commented Mar 31, 2022

The test service is currently only used by integration tests. There is a builder pattern for building a node with the wanted features. Most of these integration tests should be rewritten with Zombienet. This will require a binary that can be started. This binary should basically expose the builder pattern via cli.

The builder currently also uses in memory addresses for libp2p. This will not work when the nodes are their own processes. So, this needs to be changed as well to also support normal libp2p multi addresses.

Cc @pepoviola

@skunert
Copy link
Contributor

skunert commented Apr 7, 2022

@bkchr That means we also need the polkadot test service as new binary right? To start the relay chain nodes for these integration tests.

@bkchr
Copy link
Member Author

bkchr commented Apr 8, 2022

Probably yes, but maybe we can also just use rococo as runtime. Needs to be checked.

@skunert
Copy link
Contributor

skunert commented Apr 8, 2022

@pepoviola I have draft open for the testing binary #1158.

Mostly the node remains the same from what we have in our current integration tests. From what I understand you will migrate the first test for us right?

Mostly I exposed networking configuration like node-key, so we can do address calculation in zombienet.
Supported options:

--parachain-id
--relay-chain-bootnodes
--alice, bob, ...
--reserved-nodes
--reserved-only
--node-key
--bootnodes

// following arguments are used to build specific scenarios for the tests
--use-null-consensus
--disabled-block-announcements

Will that be enough for zombienet? Let met know here if you need more options on it.

As for the relay chain nodes, will look into using rococo.

@bkchr bkchr added this to SDK Node Apr 27, 2022
@bkchr bkchr moved this to In Progress 🛠 in SDK Node Apr 27, 2022
skunert added a commit that referenced this issue May 18, 2022
* Create binary for cumulus testing node

* Fix call to wrong method

* Fix iterator bug

* Add real networking to polkadot node

* Allow using of file chain specs

* Implement export of wasm blob and genesis state

* Add parachain id to test service export

* Remove debug logs

* Fix main.rs

* Do not use cli from polkadot-collator

* Add tracing dependency

* Improve cli structure

* Use struct instead of enum for export commands

* Add missing license header

* Fix benchmark

* add build-spec subcommand (#19)

* add build-spec subcommand

* reorder args

* Fix formatting

* Add zombienet test (#26)

* add migrated tests

* rename test files

* uncomment args and remove extra collator node

* Fix indentation (#27)

* add migrated tests

* rename test files

* uncomment args and remove extra collator node

* fix identation

* Review comments

* Remove unwanted version changes

Co-authored-by: Sebastian Kunert <[email protected]>
Co-authored-by: Javier Viola <[email protected]>
@skunert skunert closed this as completed May 20, 2022
Repository owner moved this from In Progress 🛠 to Done ✅ in SDK Node May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

2 participants