This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 379
Provide binary for test service #1128
Comments
@bkchr That means we also need the polkadot test service as new binary right? To start the relay chain nodes for these integration tests. |
Probably yes, but maybe we can also just use rococo as runtime. Needs to be checked. |
@pepoviola I have draft open for the testing binary #1158. Mostly the node remains the same from what we have in our current integration tests. From what I understand you will migrate the first test for us right? Mostly I exposed networking configuration like node-key, so we can do address calculation in zombienet.
Will that be enough for zombienet? Let met know here if you need more options on it. As for the relay chain nodes, will look into using rococo. |
skunert
added a commit
that referenced
this issue
May 18, 2022
* Create binary for cumulus testing node * Fix call to wrong method * Fix iterator bug * Add real networking to polkadot node * Allow using of file chain specs * Implement export of wasm blob and genesis state * Add parachain id to test service export * Remove debug logs * Fix main.rs * Do not use cli from polkadot-collator * Add tracing dependency * Improve cli structure * Use struct instead of enum for export commands * Add missing license header * Fix benchmark * add build-spec subcommand (#19) * add build-spec subcommand * reorder args * Fix formatting * Add zombienet test (#26) * add migrated tests * rename test files * uncomment args and remove extra collator node * Fix indentation (#27) * add migrated tests * rename test files * uncomment args and remove extra collator node * fix identation * Review comments * Remove unwanted version changes Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: Javier Viola <[email protected]>
Repository owner
moved this from In Progress 🛠
to Done ✅
in SDK Node
May 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The test service is currently only used by integration tests. There is a builder pattern for building a node with the wanted features. Most of these integration tests should be rewritten with Zombienet. This will require a binary that can be started. This binary should basically expose the builder pattern via cli.
The builder currently also uses in memory addresses for libp2p. This will not work when the nodes are their own processes. So, this needs to be changed as well to also support normal libp2p multi addresses.
Cc @pepoviola
The text was updated successfully, but these errors were encountered: