This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 379
Make functionality to read relay state proof entries public #1135
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
732e225
add read entry and read optional entry to RelayChainStateProof pub me…
4meta5 62383f2
rm toolchain
4meta5 71a3a65
docs
4meta5 0d94112
Merge branch 'master' into amar-make-read-entry-public
4meta5 6bedf79
Update pallets/parachain-system/src/relay_state_snapshot.rs
bkchr 68eceb8
Merge branch 'master' into amar-make-read-entry-public
4meta5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not directly expose the functions to read the babe randomness? As we do for all the other values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we will need functions for every value we would like to get. This will be at least:
It is less code to write one
read_entry<T>
which is generic over the successful result value returned.This approach also requires adding a new function if we ever want to read a new value from the
RelayChainStateProof
and that comes with a release delay so it is not preferred.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get what you say, but currently it also requires that you add these values before on the client side :P
We can add this function, I don't really care, but then please add some docs :)