Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.7.4 #701

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Release 3.7.4 #701

merged 2 commits into from
Feb 7, 2025

Conversation

serban300
Copy link
Contributor

No description provided.

@serban300 serban300 requested a review from gui1117 February 5, 2025 07:35
@serban300 serban300 self-assigned this Feb 5, 2025
@serban300
Copy link
Contributor Author

serban300 commented Feb 5, 2025

Related to #688 , I tested v3.7.4 with:

  1. https://github.com/tangle-network/gadget
git clone https://github.com/tangle-network/gadget
cd gadget/

added to `Cargo.toml`:
[patch.crates-io]
parity-scale-codec = { path = "../parity-scale-codec" }
parity-scale-codec-derive = { path = "../parity-scale-codec/derive" }

cd blueprints/incredible-squaring
cargo update -p parity-scale-codec-derive -p parity-scale-codec
cargo check
  1. https://github.com/open-web3-stack/open-runtime-module-library.git
git clone https://github.com/open-web3-stack/open-runtime-module-library.git
cd open-runtime-module-library
make `Cargo.toml`

added to `Cargo.toml`:
[patch.crates-io]
parity-scale-codec = { path = "../parity-scale-codec" }
parity-scale-codec-derive = { path = "../parity-scale-codec/derive" }

cargo update -p parity-scale-codec-derive -p parity-scale-codec -p frame-support-procedural
cargo clippy -- -D warnings
cargo test

gui1117
gui1117 previously approved these changes Feb 5, 2025
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the CHANGELOG, I forgot to put the 653 into the changelog in the past:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fa565d5..c15edb7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,9 +5,15 @@ All notable changes to this crate are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this crate adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+## 3.7.4 - 2025-02-05
 
-### [3.7.3] - 2025-01-30
+### Added
+
+- Disallow duplicate indexes using constant evaluation ([#653](https://github.com/paritytech/parity-scale-codec/pull/653))
+
+## [3.7.3] - 2025-01-30
+
+### Added
 
 - Fix added bounds in `Encode` and other derive macros. ([#689](https://github.com/paritytech/parity-scale-codec/pull/689))
 

@serban300 serban300 mentioned this pull request Feb 5, 2025
@gui1117
Copy link
Contributor

gui1117 commented Feb 5, 2025

Note that if we run cargo test we can some error:

error[E0080]: evaluation of constant value failed
   --> asset-registry/src/mock/para.rs:350:1
    |
350 | / construct_runtime!(
351 | |     pub enum Runtime {
352 | |         System: frame_system,
353 | |         Balances: pallet_balances,
...   |
364 | |     }
365 | | );
    | |_^ the evaluated program panicked at 'Found variants that have duplicate indexes. Both `CumulusXcm` and `Void` have the index `3`. Use different indexes for each variant.', asset-registry/src/mock/para.rs:350:1
    |
    = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `::core::panic` (in Nightly builds, run with -Z macro-backtrace for more info)

people will have to update frame-support first.

@gui1117 gui1117 dismissed their stale review February 5, 2025 08:14

I am not sure yet. People will complain that frame-support doesn't compile. Maybe we should update frame-support first.

@serban300
Copy link
Contributor Author

serban300 commented Feb 5, 2025

We can update the CHANGELOG, I forgot to put the 653 into the changelog in the past:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fa565d5..c15edb7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,9 +5,15 @@ All notable changes to this crate are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this crate adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+## 3.7.4 - 2025-02-05
 
-### [3.7.3] - 2025-01-30
+### Added
+
+- Disallow duplicate indexes using constant evaluation ([#653](https://github.com/paritytech/parity-scale-codec/pull/653))
+
+## [3.7.3] - 2025-01-30
+
+### Added
 
 - Fix added bounds in `Encode` and other derive macros. ([#689](https://github.com/paritytech/parity-scale-codec/pull/689))
 

Done

@serban300
Copy link
Contributor Author

Note that if we run cargo test we can some error:

error[E0080]: evaluation of constant value failed
   --> asset-registry/src/mock/para.rs:350:1
    |
350 | / construct_runtime!(
351 | |     pub enum Runtime {
352 | |         System: frame_system,
353 | |         Balances: pallet_balances,
...   |
364 | |     }
365 | | );
    | |_^ the evaluated program panicked at 'Found variants that have duplicate indexes. Both `CumulusXcm` and `Void` have the index `3`. Use different indexes for each variant.', asset-registry/src/mock/para.rs:350:1
    |
    = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `::core::panic` (in Nightly builds, run with -Z macro-backtrace for more info)

people will have to update frame-support first.

Yes, you're right. We should patch frame-support probably

@serban300
Copy link
Contributor Author

@serban300
Copy link
Contributor Author

Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked compilation of open-runtime-module-library.

Looks good to me.

@serban300 serban300 merged commit ff5a070 into paritytech:master Feb 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants