Skip to content

Commit

Permalink
Remove NotConcrete error (#3867)
Browse files Browse the repository at this point in the history
# Description
- Link to issue: #3651

polkadot address: 19nSqFQorfF2HxD3oBzWM3oCh4SaCRKWt1yvmgaPYGCo71J
  • Loading branch information
chungquantin authored and sandreim committed Apr 18, 2024
1 parent e1ec8b9 commit e29535f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
9 changes: 6 additions & 3 deletions polkadot/xcm/pallet-xcm/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -535,20 +535,24 @@ pub mod pallet {
LockNotFound,
/// The unlock operation cannot succeed because there are still consumers of the lock.
InUse,
/// Invalid non-concrete asset.
InvalidAssetNotConcrete,
/// Invalid asset, reserve chain could not be determined for it.
#[codec(index = 21)]
InvalidAssetUnknownReserve,
/// Invalid asset, do not support remote asset reserves with different fees reserves.
#[codec(index = 22)]
InvalidAssetUnsupportedReserve,
/// Too many assets with different reserve locations have been attempted for transfer.
#[codec(index = 23)]
TooManyReserves,
/// Local XCM execution incomplete.
#[codec(index = 24)]
LocalExecutionIncomplete,
/// Could not decode XCM.
#[codec(index = 25)]
UnableToDecode,
/// XCM encoded length is too large.
/// Returned when an XCM encoded length is larger than `MaxXcmEncodedSize`.
#[codec(index = 26)]
XcmTooLarge,
}

Expand All @@ -565,7 +569,6 @@ pub mod pallet {
impl<T: Config> From<AssetTransferError> for Error<T> {
fn from(e: AssetTransferError) -> Self {
match e {
AssetTransferError::NotConcrete => Error::<T>::InvalidAssetNotConcrete,
AssetTransferError::UnknownReserve => Error::<T>::InvalidAssetUnknownReserve,
}
}
Expand Down
2 changes: 0 additions & 2 deletions polkadot/xcm/xcm-executor/src/traits/asset_transfer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ use xcm::prelude::*;
/// Errors related to determining asset transfer support.
#[derive(Copy, Clone, Encode, Decode, Eq, PartialEq, Debug, TypeInfo)]
pub enum Error {
/// Invalid non-concrete asset.
NotConcrete,
/// Reserve chain could not be determined for assets.
UnknownReserve,
}
Expand Down

0 comments on commit e29535f

Please sign in to comment.