Add Missing Events for Balances Pallet

[muharem]

There are cases in the Balances pallet where events are missing, which might impact systems relying on balance updates for accounting. The known cases include:

1. fungible trait impl for Hold/Release operations:
   No events are emitted when a balance is placed on hold or released.
2. Burn/Mint Events for Credit/Debt drops
   When Credit or Debt fungible types are dropped, the total issuance is adjusted, but no Burn or Mint events are published.

Please verify these cases and check if any other major events are missing in the Balances pallet.

[Doordashcon]

Hello @muharem

As per my investigation:

Hold & Release Events

impl<T: Config<I>, I: 'static> fungible::MutateHold<T::AccountId> for Pallet<T, I> {
	fn done_hold(reason: &Self::Reason, who: &T::AccountId, amount: Self::Balance) {
        Self::deposit_event(Event::<T, I>::Holding { reason: *reason, who: who.clone(), amount });
    }
    fn done_release(reason: &Self::Reason, who: &T::AccountId, amount: Self::Balance) {
        Self::deposit_event(Event::<T, I>::Released { reason: *reason, who: who.clone(), amount });
    }
}

[muharem]

Hello @muharem

As per my investigation:

Hold & Release Events

impl<T: Config, I: 'static> fungible::MutateHold<T::AccountId> for Pallet<T, I> {
fn done_hold(reason: &Self::Reason, who: &T::AccountId, amount: Self::Balance) {
Self::deposit_event(Event::<T, I>::Holding { reason: *reason, who: who.clone(), amount });
}
fn done_release(reason: &Self::Reason, who: &T::AccountId, amount: Self::Balance) {
Self::deposit_event(Event::<T, I>::Released { reason: *reason, who: who.clone(), amount });
}
}

left comment in the PR. how about burn and mint?

[Doordashcon]

left comment in the PR. how about burn and mint?

Burn

fn done_settle(who: &T::AccountId, amount: Self::Balance, dust: &Self::Balance) {
 	if dust.is_zero() {
 		Self::deposit_event(Event::<T, I>::Burned { who: who.clone(), amount: amount.clone() });
 	} else {
 		Self::deposit_event(Event::<T, I>::BurnedWithDust { who: who.clone(), amount: amount.clone(), dust: *dust});
 	}
 }

Mint

fn done_resolve(who: &T::AccountId, amount: Self::Balance) {
 	Self::deposit_event(Event::<T, I>::Minted { who: who.clone(), amount })
 }

@muharem looking for other instances of missing events.

[muharem]

@Doordashcon its not correct. settle is not burn and resolve is not mint. you can do both without burning and minting. also I think it does not really matter if you burn 10 as amount and 0.1 as dust. you just burned 10.1

[muharem]

@Doordashcon let me know if something is not clear. I think these events publishing should be integrated into the on drops impls of HandleImbalanceDrop trait. But please double check this.

[Doordashcon]

@muharem

Burn/Mint Events for Credit/Debt drops
When Credit or Debt fungible types are dropped, the total issuance is adjusted, but no Burn or Mint events are published.

This a bit unclear, if the Drops handle TotalIssuance adjustments, should the event emitted be Burn and Mint or TotalIssuanceForced.

[muharem]

@muharem

Burn/Mint Events for Credit/Debt drops
When Credit or Debt fungible types are dropped, the total issuance is adjusted, but no Burn or Mint events are published.

This a bit unclear, if the Drops handle TotalIssuance adjustments, should the event emitted be Burn and Mint or TotalIssuanceForced.

in my option Burn and Mint. it is not forced. it seem like forced event ie meant specifically for that call under the root origin

[Yung-Beef]

Any update on this?

[Doordashcon]

This week @Yung-Beef