Add Missing Events for Balances Pallet #7250
Open
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
reviewed
Jan 20, 2025
substrate/frame/balances/src/lib.rs
Outdated
Comment on lines
388
to
391
| /// Some balance of who is currently being held. | ||
| Holding { reason: T::RuntimeHoldReason, who: T::AccountId, amount: T::Balance }, | ||
| /// Some balance of who has been released. | ||
| Released { reason: T::RuntimeHoldReason, who: T::AccountId, amount: T::Balance } |
There was a problem hiding this comment.
may be?
Suggested change
| /// Some balance of who is currently being held. | |
| Holding { reason: T::RuntimeHoldReason, who: T::AccountId, amount: T::Balance }, | |
| /// Some balance of who has been released. | |
| Released { reason: T::RuntimeHoldReason, who: T::AccountId, amount: T::Balance } | |
| /// Some balance was placed on hold. | |
| Held { reason: T::RuntimeHoldReason, who: T::AccountId, amount: T::Balance }, | |
| /// Some balance was released from hold. | |
| Released { reason: T::RuntimeHoldReason, who: T::AccountId, amount: T::Balance } |
|
Any update on this? |
|
Why draft? Is it okay to review? |
gui1117
reviewed
Mar 10, 2025
| @@ -62,7 +64,7 @@ impl<B: Balance, OnDrop: HandleImbalanceDrop<B>, OppositeOnDrop: HandleImbalance | |||
| { | |||
| fn drop(&mut self) { | |||
| if !self.amount.is_zero() { | |||
| OnDrop::handle(self.amount) | |||
| OnDrop::handle(self.amount) // here. | |||
| fn done_release(reason: &Self::Reason, who: &T::AccountId, amount: Self::Balance) { | ||
| Self::deposit_event(Event::<T, I>::Released { reason: *reason, who: who.clone(), amount }); | ||
| } | ||
| } |
There was a problem hiding this comment.
let's implement all of them no?
fn done_hold(_reason: &Self::Reason, _who: &AccountId, _amount: Self::Balance) {}
fn done_release(_reason: &Self::Reason, _who: &AccountId, _amount: Self::Balance) {}
fn done_burn_held(_reason: &Self::Reason, _who: &AccountId, _amount: Self::Balance) {}
fn done_transfer_on_hold(
_reason: &Self::Reason,
_source: &AccountId,
_dest: &AccountId,
_amount: Self::Balance,
) {
}
fn done_transfer_and_hold(
_reason: &Self::Reason,
_source: &AccountId,
_dest: &AccountId,
_transferred: Self::Balance,
) {
}
| @@ -343,6 +350,20 @@ impl<T: Config<I>, I: 'static> fungible::MutateFreeze<T::AccountId> for Pallet<T | |||
| } | |||
| } | |||
|
|
|||
| impl<T: Config<I>, I: 'static> HandleImbalanceDrop<T::Balance> for fungible::DecreaseIssuance<T::AccountId, Pallet<T, I>> { | |||
There was a problem hiding this comment.
Either you make fungible::DecreaseIssuance generic over the event, or you need to recreate an implementation of HandleImbalanceDrop here to a new type only for pallet-balances.
Because this will not compile.
There was a problem hiding this comment.
We can implement for PositiveImbalance and NegativeImbalance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resolve #6974