Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing of thechain-spec-builder image #5387

Merged
merged 10 commits into from
Aug 19, 2024
Merged

Fix publishing of thechain-spec-builder image #5387

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2fbd138
fix release_id propagation to the steps
EgorPopelyaev Aug 15, 2024
f100d51
set env vars differently
EgorPopelyaev Aug 16, 2024
8b7d403
debug
EgorPopelyaev Aug 16, 2024
35cc74e
debug2
EgorPopelyaev Aug 16, 2024
cab6344
set release_id and version explicitly
EgorPopelyaev Aug 16, 2024
4f5cfe1
replace GITHUB_ENV with GITHUB_OUTPUT
EgorPopelyaev Aug 16, 2024
18c4eef
fix release tag for the chain-spec-builder
EgorPopelyaev Aug 16, 2024
86ac29e
fix typo
EgorPopelyaev Aug 16, 2024
9aaf47c
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
EgorPopelyaev Aug 16, 2024
7f3c0cc
Merge branch 'master' into ep-fix-publishing-chain-spec-builder-image
EgorPopelyaev Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/workflows/release-50_publish-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,13 @@ env:
# EVENT_ACTION: ${{ github.event.action }}
EVENT_NAME: ${{ github.event_name }}
IMAGE_TYPE: ${{ inputs.image_type }}
VERSION: ${{ inputs.version }}

jobs:
validate-inputs:
runs-on: ubuntu-latest
outputs:
version: ${{ steps.validate_inputs.outputs.VERSION }}
release_id: ${{ steps.validate_inputs.outputs.RELEASE_ID }}
stable_tag: ${{ steps.validate_inputs.outputs.stable_tag }}

steps:
Expand All @@ -93,17 +94,20 @@ jobs:
. ./.github/scripts/common/lib.sh

VERSION=$(filter_version_from_input "${{ inputs.version }}")
echo "VERSION=${VERSION}" >> $GITHUB_ENV
echo "VERSION=${VERSION}" >> $GITHUB_OUTPUT

RELEASE_ID=$(check_release_id "${{ inputs.release_id }}")
echo "RELEASE_ID=${RELEASE_ID}" >> $GITHUB_ENV
echo "RELEASE_ID=${RELEASE_ID}" >> $GITHUB_OUTPUT

echo "Release ID: $RELEASE_ID"

STABLE_TAG=$(validate_stable_tag ${{ inputs.stable_tag }})
echo "stable_tag=${STABLE_TAG}" >> $GITHUB_OUTPUT

fetch-artifacts: # this job will be triggered for the polkadot-parachain rc and release or polkadot rc image build
if: ${{ inputs.binary == 'polkadot-parachain' || inputs.binary == 'chain-spec-builder' || inputs.image_type == 'rc' }}
runs-on: ubuntu-latest
needs: [validate-inputs]

steps:
- name: Checkout sources
Expand All @@ -129,6 +133,7 @@ jobs:
run: |
. ./.github/scripts/common/lib.sh

VERSION="${{ needs.validate-inputs.outputs.VERSION }}"
fetch_release_artifacts_from_s3

- name: Fetch chain-spec-builder rc artifacts or release artifacts based on release id
Expand All @@ -137,6 +142,7 @@ jobs:
run: |
. ./.github/scripts/common/lib.sh

RELEASE_ID="${{ needs.validate-inputs.outputs.RELEASE_ID }}"
fetch_release_artifacts

- name: Upload artifacts
Expand Down Expand Up @@ -181,8 +187,7 @@ jobs:
run: |
. ./.github/scripts/common/lib.sh

RELEASE_ID=$(check_release_id "${{ inputs.release_id }}")
release=release-$RELEASE_ID && \
release="release-${{ needs.validate-inputs.outputs.RELEASE_ID }}" && \
echo "release=${release}" >> $GITHUB_OUTPUT

commit=$(git rev-parse --short HEAD) && \
Expand All @@ -198,9 +203,14 @@ jobs:
id: fetch_release_refs
run: |
chmod a+rx $BINARY
[[ $BINARY != 'chain-spec-builder' ]] && VERSION=$(./$BINARY --version | awk '{ print $2 }' )

release=$( echo $VERSION | cut -f1 -d- )
if [[ $BINARY != 'chain-spec-builder' ]]; then
VERSION=$(./$BINARY --version | awk '{ print $2 }' )
release=$( echo $VERSION | cut -f1 -d- )
else
release=$(echo ${{ needs.validate-inputs.outputs.VERSION }} | sed 's/^v//')
fi

echo "tag=latest" >> $GITHUB_OUTPUT
echo "release=${release}" >> $GITHUB_OUTPUT
echo "stable=${{ needs.validate-inputs.outputs.stable_tag }}" >> $GITHUB_OUTPUT
Expand Down
Loading