-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage bounds for pallet staking
and clean up deprecated non paged exposure storages
#6445
Closed
Closed
Changes from 1 commit
Commits
Show all changes
148 commits
Select commit
Hold shift + click to select a range
6c808b6
add MaxInvulnerables
re-gius 1b18bb1
add `MaxActiveValidators`
re-gius 0ac60af
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 4edb8e1
fix + start working on migrations
re-gius 65c7de6
nit (typo)
re-gius 35069c9
fix migrations for `BoundedVec`
re-gius d4b15af
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius eb93a70
Migrate `ErasRewardPoints`
re-gius 58cf45d
small fixes - `BoundedBTreeMap`
re-gius 292c5d0
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 74f2055
fix
re-gius 63f2c5e
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius b249a67
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 362f505
Adapt to new recent `DisabledValidators` change
re-gius 4f21d53
Change `MaxActiveValidators` to `MaxWinners`
re-gius e258baf
undo change from another PR
re-gius 4b7d896
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 01e2233
small fix for `MaxWinners`
re-gius 243bec8
small fixes
re-gius a599afc
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 9a25fbc
Remove deprecated `ErasStakers` and `ErasStakersClipped`
re-gius 98daabc
Fixes from #5986
re-gius aec5087
nit
re-gius 36204da
remove unused import
re-gius 18e9bee
fix `Invulnerables` migration
re-gius cbfd4a5
Undo migrations change
re-gius b5cbfec
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 9ca25a1
debug
re-gius 10e7295
Increase `MaxInvulnerables` to 20 + fix migrations msg
re-gius b3186b1
fix - `MaxInvulnerables` = 20
re-gius 336137a
Fix tests
re-gius c1911e1
Fix impl
re-gius 2ac794e
Fix `Invulnerables` limit in benchmarking
re-gius 583e46d
Bound `ExposurePage.others` with `MaxExposurePageSize`
re-gius 6347a8c
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 9e82b85
fix `TypeInfo` error
re-gius 1db7f39
fix benchmarking limit
re-gius f996a97
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius e030506
bound `BondedEras` Vec
re-gius 3ab45d9
Add migration for `BondedEras`
re-gius a980daa
fix tests attempt
re-gius 827e898
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius c4d5142
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius df8e567
bound `ClaimedRewards`
re-gius c066632
Use `WeakBoundedVec` for `EraStakersPaged` paged exposures
re-gius 686b6b3
Turn more `BoundedVec` into `WeakBoundedVec`
re-gius 9cf2263
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 21ad9ea
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius ca881ac
add import
re-gius e986264
Migrate `MaxValidatorsCount` from storage to dynamic param + fixes
re-gius ea59383
Use `MaxValidatorsCount` to bound `ErasRewardPoints` `BoundedVec`
re-gius 9a21b8f
remove unused imports
re-gius 47863bb
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 50ce1a1
Use `MaxDisabledValidators` to bound disabled validators
re-gius 40ccdec
fix `Vec`/`BoundedVec`
re-gius c3365a6
Fix `WeakBoundedVec` and `MaxValidatorsCount`
re-gius 584fe53
fix
re-gius 5333a7d
fix
re-gius 31a9300
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 898d469
`BoundedVec` fix in tests
re-gius 32df05d
fix
re-gius 7bc9b98
Use `MaxValidatorsCount` for limit checks
re-gius 9c4d874
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 536d5c5
undo wrong changes
re-gius 608ec88
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 76469ea
Increase benchmarking `MaxValidators` limit
re-gius fb1a4fa
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 181fe4d
Remove `MaxValidators` from benchmarking config and use `MaxValidator…
re-gius b1f5f97
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 9c002c1
fix
re-gius 503a7d9
Use `MaxValidatorsCount` for slashing pallet
re-gius 63a18b1
Fix migration comments
re-gius 49059c0
Restore benchmarking for slashing
re-gius efde7a7
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 8186680
fix
re-gius 3fb6ca7
fix
re-gius 66923a4
fix benchmarking config
re-gius bec0544
fix
re-gius 3708085
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 73af22a
Remove `unbounded` for `ClaimedRewards`
re-gius 1139689
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 2bda8eb
Update from re-gius running command 'prdoc --bump major --audience ru…
fe3147b
fix prdoc
re-gius cd8a0c3
fix prdoc
re-gius 5b15e24
debug failing benchmark
re-gius 9d055a8
benchmarking error debug
re-gius 07b021b
undo debug changes
re-gius 87e0e46
debug 1
re-gius 473e0ff
debug 1
re-gius eb64ffc
debug 1
re-gius 74d6c7a
debug dynamic param
re-gius 94f5b31
restore after debugging
re-gius 7b1fc5e
Fix bound comparison to `MaxValidatorsCount`
re-gius cf9d8c3
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius c265974
Use `MaxValidatorsCount` limit to check validators
re-gius bb5229c
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 6588714
fix staking tests
re-gius 4754629
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 76a2d4b
Fix staking tests
re-gius 67c41fa
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius bd28db5
fix benchmark
re-gius 043b7d6
comment nit
re-gius 68481f4
Always link `BondingDuration` to `MaxBondedEras` in tests
re-gius 312904e
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius d508f8d
Remove old `MaxValidatorCount` from expected default genesis config
re-gius 529fa0f
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 17eeef7
Update cumulus/parachains/integration-tests/emulated/chains/relays/we…
re-gius 21a12d1
Fix PR title in prdoc and migrations for old deprecated storage items
re-gius e2fa0ca
Update substrate/frame/staking/src/lib.rs
re-gius 4bf3cd6
add debug msg
re-gius f7c1fe4
fix migrations
re-gius c881bb0
fix comments + CR
re-gius 306cd41
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 2da736a
Add more debugging `expect(...)` in tests
re-gius 831f1b0
fix migrations
re-gius 3702ce5
prefix with `_` unused variables
re-gius 489fc9d
remove unused `page_size` fn arg + fix tests
re-gius 65fc95b
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 9c88d39
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius a5e98e6
fix merge
re-gius 7b82520
fix merge
re-gius 30520af
fix merge
re-gius 0d47dc5
expand errors msg for invulnerables
re-gius 4b58f0a
using `default()` to create empty `WeakBoundedVec`
re-gius 33e59b2
migration fix attempt
re-gius c889905
nit
re-gius 300b7f9
migration fix
re-gius fc63dc7
fix migrations
re-gius 720c9eb
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius a065a91
Set `MaxValidatorsCount` equal to `MaxAuthorities`
re-gius 483eb03
Update polkadot/runtime/test-runtime/src/lib.rs
re-gius 7aeb8a5
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius c51d09b
fix comment
re-gius 1a9be6b
fix
re-gius 235a260
Update pr_6445.prdoc from semver CI
re-gius 83a888b
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius b2efa18
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 78539f0
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius 1a39de4
add more info on deleted storage items to prdoc
re-gius 3b7bc95
add error when processing non-paged exposures
re-gius dc93f0f
Update substrate/frame/staking/src/pallet/mod.rs
re-gius e6c9942
Update substrate/primitives/staking/src/lib.rs
re-gius d91414b
Update substrate/frame/staking/src/lib.rs
re-gius 9d2e835
Update substrate/frame/staking/src/lib.rs
re-gius 88d20a3
Update substrate/frame/staking/src/lib.rs
re-gius 649b0f9
fmt
re-gius 6c9806c
Change `MaxValidatorsCount` in test runtime
re-gius 6ca4347
Merge branch 'master' into re-gius/staking/add-storage-bounds
re-gius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge jump, is there a reason why the MaxAuthorities is so big in the test runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right! Then it's probably better to revert the change in that case, adding also a comment: 6c9806c