-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcm: fix local/remote exports when inner routers return NotApplicable
#6645
Conversation
/cmd fmt |
Command "fmt" has started 🚀 See logs here |
Command "fmt" has finished ✅ See logs here |
All GitHub workflows were cancelled due to failure one of the required jobs. |
/cmd prdoc --audience runtime_dev --bump patch |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6645-to-stable2407
git worktree add --checkout .worktree/backport-6645-to-stable2407 backport-6645-to-stable2407
cd .worktree/backport-6645-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 1c0b610078611dfebc082be52e77109ea4517e48
git push --force-with-lease |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6645-to-stable2409
git worktree add --checkout .worktree/backport-6645-to-stable2409 backport-6645-to-stable2409
cd .worktree/backport-6645-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 1c0b610078611dfebc082be52e77109ea4517e48
git push --force-with-lease |
…e` (#6645) This PR addresses two small fixes: 1. Fixed a typo ("as as") found on the way. 2. Resolved a bug in the `local/remote exporters` used for bridging. Previously, they consumed `dest` and `msg` without returning them when inner routers/exporters failed with `NotApplicable`. This PR ensures compliance with the [`SendXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/traits.rs#L449-L450) and [`ExportXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/traits/export.rs#L44-L45) traits. --------- Co-authored-by: GitHub Action <[email protected]>
Backport #6645 into `stable2407` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <[email protected]>
Backport #6645 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <[email protected]>
…e` (paritytech#6645) This PR addresses two small fixes: 1. Fixed a typo ("as as") found on the way. 2. Resolved a bug in the `local/remote exporters` used for bridging. Previously, they consumed `dest` and `msg` without returning them when inner routers/exporters failed with `NotApplicable`. This PR ensures compliance with the [`SendXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/traits.rs#L449-L450) and [`ExportXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/traits/export.rs#L44-L45) traits. --------- Co-authored-by: GitHub Action <[email protected]>
…e` (paritytech#6645) This PR addresses two small fixes: 1. Fixed a typo ("as as") found on the way. 2. Resolved a bug in the `local/remote exporters` used for bridging. Previously, they consumed `dest` and `msg` without returning them when inner routers/exporters failed with `NotApplicable`. This PR ensures compliance with the [`SendXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/traits.rs#L449-L450) and [`ExportXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/traits/export.rs#L44-L45) traits. --------- Co-authored-by: GitHub Action <[email protected]>
* [stable2407] Backport paritytech#5713 (paritytech#5739) Backport paritytech#5713 into `stable2407` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> * [stable2407] Backport paritytech#3049 (paritytech#5734) Backport paritytech#3049 into `stable2407` from bgallois. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Benjamin Gallois <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Move prdocs to release folder * Bump polkadot node version * Update plan * [stable2407] Backport Fix parity-publish (paritytech#5670) (paritytech#6019) Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> * [stable2407] Backport docker fix to 2407 (paritytech#6017) This PR backports fixes for the docker publishing flow from master: - paritytech#5896 - paritytech#5387 * [stable2407] Backport paritytech#5913 (paritytech#6004) Backport paritytech#5913 into `stable2407` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: Egor_P <[email protected]> * [stable2407] Backport paritytech#4803 (paritytech#6097) Backport paritytech#4803 into `stable2407` from gotnoshoeson. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Miles Patterson <[email protected]> * [stable2407] Backport paritytech#5599 (paritytech#6068) Backport paritytech#5599 into `stable2407` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Shawn Tabrizi <[email protected]> * [stable2407] Backport paritytech#6205 (paritytech#6238) Backport paritytech#6205 into `stable2407` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: command-bot <> * [stable2407] Backport paritytech#6148 (paritytech#6232) Backport paritytech#6148 into `stable2407` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <[email protected]> * Bump node version * Move prdocs * Update plan * Apply plan * [stable2407] Backport paritytech#6417 (paritytech#6437) Backport paritytech#6417 into `stable2407` from alindima. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Alin Dima <[email protected]> * [Release|CI/CD] Fix audiences changelog template (paritytech#6444) This PR addresses an issue mentioned [here](paritytech#6424 (comment)). The problem was that when the prdoc file has two audiences, but only one description like in [prdoc_5660](https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/1.16.0/pr_5660.prdoc) it was ignored by the template. * [stable2407] Backport paritytech#6526 (paritytech#6530) Backport paritytech#6526 into `stable2407` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <[email protected]> * [stable2407] Backport paritytech#6645 (paritytech#6655) Backport paritytech#6645 into `stable2407` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <[email protected]> * [stable2407] Backport paritytech#6579 (paritytech#6634) Backport paritytech#6579 into `stable2407` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: Egor_P <[email protected]> * [stable2407] Backport paritytech#6603 (paritytech#6668) Backport paritytech#6603 into `stable2407` from lexnv. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Alexandru Vasile <[email protected]> * Backport paritytech#5887 to `stable2407` (paritytech#6674) This PR accompanies paritytech#6672 to make backported changes consistent across releases. --------- Co-authored-by: Egor_P <[email protected]> * [stable2407] Backport paritytech#6031 (paritytech#6106) Backport paritytech#6031 into `stable2407` from drewstone. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: drewstone <[email protected]> Co-authored-by: Egor_P <[email protected]> * [stable2407] Backport paritytech#6080 (paritytech#6180) Backport paritytech#6080 into `stable2407` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: Egor_P <[email protected]> * [stable2407] Backport paritytech#6540 (paritytech#6591) Backport paritytech#6540 into `stable2407` from Ank4n. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Ankan <[email protected]> Co-authored-by: Egor_P <[email protected]> * [stable2407] Backport paritytech#6506 (paritytech#6657) Backport paritytech#6506 into `stable2407` from Dinonard. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Dino Pačandi <[email protected]> Co-authored-by: Egor_P <[email protected]> * [stable2407] Backport paritytech#6459 (paritytech#6663) Backport paritytech#6459 into `stable2407` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: Egor_P <[email protected]> * Bump polkadot node version * Move prdoxs to release folder * Apply plan * Update Cargo.lock * [stable2407] Backport paritytech#6690 (paritytech#6798) Backport paritytech#6690 into `stable2407` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Alexandru Gheorghe <[email protected]> * [stable2407] Backport paritytech#6729 (paritytech#6828) Backport paritytech#6729 into `stable2407` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> * [stable2407] Backport paritytech#6662 (paritytech#6801) Backport paritytech#6662 into `stable2407` from eskimor. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: eskimor <[email protected]> Co-authored-by: Andrei Sandu <[email protected]> * [stable2407] Backport paritytech#5311 (paritytech#6804) Backport paritytech#5311 into `stable2407` from Doordashcon. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Doordashcon <[email protected]> * [stable2407] Backport paritytech#6696 (paritytech#6839) Backport paritytech#6696 into `stable2407` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> * [stable2407] Backport paritytech#6864 (paritytech#6877) Backport paritytech#6864 into `stable2407` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Alexandru Gheorghe <[email protected]> * [stable2407] Backport paritytech#7050 (paritytech#7058) Backport paritytech#7050 into `stable2407` from skunert. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Sebastian Kunert <[email protected]> * [stable2407] Backport paritytech#7013 (paritytech#7015) Backport paritytech#7013 into `stable2407` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: EgorPopelyaev <[email protected]> * Switch to parity-large runners to be able to run on the github (paritytech#7113) * Move prdocs to release folder * Bump node_version * [stable2407] Backport paritytech#7116 (paritytech#7135) Backport paritytech#7116 into `stable2407` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Alexandru Gheorghe <[email protected]> * Move prdoc to release folder * [stable2407] Backport paritytech#6807 (paritytech#7155) Backport paritytech#6807 into `stable2407` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> * [stable2407] Backport paritytech#6973 (paritytech#7159) Backport paritytech#6973 into `stable2407` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> * [stable2407] Backport paritytech#6971 (paritytech#7172) Backport paritytech#6971 into `stable2407` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> * Move prdocs to release folder * Apply plan * [stable2407] Backport paritytech#7365 (paritytech#7380) Backport paritytech#7365 into `stable2407` from vgantchev. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Valery Gantchev <[email protected]> * [stable2407] Backport paritytech#7437 (paritytech#7465) Backport paritytech#7437 into `stable2407` from serban300. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Serban Iorga <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> * [stable2407] Backport paritytech#7446 (paritytech#7460) Backport paritytech#7446 into `stable2407` from serban300. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Serban Iorga <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Update plan * Apply changes * Move prdocs to release folder * Bump node version * Backport 1.12.0: check-weight: Disable total pov size check for mandatory extrinsics (paritytech#4592) Backport of paritytech#4571 --------- Co-authored-by: command-bot <> * Implement `CheckMetadataHash` extension (paritytech#4274) (paritytech#4619) This implements the `CheckMetadataHash` extension as described in [RFC78](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html). Besides the signed extension, the `substrate-wasm-builder` is extended to support generating the metadata-hash. Closes: paritytech#291 --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Liam Aharon <[email protected]> Co-authored-by: Kian Paimani <[email protected]> * init bifrost-polkadot-base * fix: add legacy transferrable balance to currency trait (#1) * wasm-builder(cherry-pick): Also set mcpu for c deps (paritytech#3777) * update Cargo.lock * feat: add a getter function to retrieve keystore raw value --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: paritytech-cmd-bot-polkadot-sdk[bot] <179002856+paritytech-cmd-bot-polkadot-sdk[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Benjamin Gallois <[email protected]> Co-authored-by: EgorPopelyaev <[email protected]> Co-authored-by: Morgan Adamiec <[email protected]> Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: Miles Patterson <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: Alin Dima <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Alexandru Vasile <[email protected]> Co-authored-by: s0me0ne-unkn0wn <[email protected]> Co-authored-by: drewstone <[email protected]> Co-authored-by: Ankan <[email protected]> Co-authored-by: Dino Pačandi <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexandru Gheorghe <[email protected]> Co-authored-by: eskimor <[email protected]> Co-authored-by: Andrei Sandu <[email protected]> Co-authored-by: Doordashcon <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: Valery Gantchev <[email protected]> Co-authored-by: Serban Iorga <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Liam Aharon <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
This PR addresses two small fixes:
local/remote exporters
used for bridging. Previously, they consumeddest
andmsg
without returning them when inner routers/exporters failed withNotApplicable
. This PR ensures compliance with theSendXcm
andExportXcm
traits.TODO: