Clamp benchmark ranks to respect MaxRank

[Doordashcon]

resolves #7517

Issues

1. Compile-Time vs Runtime Rank Mismatch

• promote_fast Benchmark uses mock runtime's MaxRank during benchmark generation while allowing runtime overrides. Creating potential parameter mismatch between benchmark metadata(i.e. generated r values) and runtime configuration(i.e. T::MaxRank).

2. Static Rank Assumptions

• bump_demote Benchmark initialized members at rank 2, making it incompatible with MaxRank=1 configurations
• promote Benchmark contained hardcoded rank values (1 → 2) which fails for MaxRank=1

Changes

Dynamic Rank Clamping

// promote_fast
let target_rank = r.min(T::MaxRank::get()).try_into().unwrap();

// promote
let to_rank = (current_rank + 1).min(max_rank.try_into().unwrap());

[bkchr]

The general logic looks good, just some nit improvements to make this better :)

[bkchr]

Suggested change

	let target_rank = r.min(max_rank).try_into().unwrap();
	let target_rank = r.min(max_rank);

r and max_rank are already a u32.

[bkchr]

We should change MaxRank to u16. I don't get why ranks are u16 and MaxRank is u32.

[Doordashcon]

pub struct ConvertU16ToU32<Inner>(PhantomData<Inner>);

for BoundedVec

[bkchr]

Suggested change

log::info!("Benchmark promote_fast: r={} MaxRank={}", r, T::MaxRank::get());

[bkchr]

Then we can remove all the conversion code.

[Doordashcon]

Would need to run benchmark command for this 🙏

[bkchr]

Why? Generally we have now these weight updates once a week, that should be fine to be done as part of them.

[bkchr]

Why? Generally we have now these weight updates once a week, that should be fine to be done as part of them.

[bkchr]

Fine for now. After the pr got merged, could you do a commit to the upstream crate that has the Get trait to introduce some sort of GetInto converter type:

impl<T: Get<I>, I: Into<R>, R> Get<R> GetInto<I> {
       fn get() -> R {
              T::get().into()
       }
}