Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementable: return None instead of saturating #7846

Merged

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Mar 7, 2025

Closes #7845

@clangenb clangenb marked this pull request as ready for review March 7, 2025 14:06
@clangenb clangenb requested a review from a team as a code owner March 7, 2025 14:06
@bkchr bkchr added the T17-primitives Changes to primitives that are not covered by any other label. label Mar 8, 2025
@clangenb clangenb changed the title Incrementable returns None instead of saturating Incrementable: return None instead of saturating Mar 8, 2025
@clangenb
Copy link
Contributor Author

clangenb commented Mar 8, 2025

/cmd prdoc --audience runtime_dev runtime_user --bump patch

Co-authored-by: Guillaume Thiolliere <[email protected]>
@clangenb
Copy link
Contributor Author

Nice, thanks for the reviews. 🚀 Can someone add the PR to the merge queue?

@gui1117 gui1117 enabled auto-merge March 10, 2025 06:59
@gui1117 gui1117 added this pull request to the merge queue Mar 10, 2025
Merged via the queue into paritytech:master with commit 007565a Mar 10, 2025
244 of 253 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T17-primitives Changes to primitives that are not covered by any other label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frame_support::Incrementable: shouldn't it return None if max is reached?
3 participants