Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XCM decoding inconsistencies #7856

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Fix XCM decoding inconsistencies #7856

wants to merge 22 commits into from

Conversation

serban300
Copy link
Contributor

This PR includes:

  • deduplicating some XCM decoding logic
  • making use of decode_with_depth_limit consistently for VersionedXcm
  • some cleanup

@serban300 serban300 added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. labels Mar 10, 2025
@serban300 serban300 self-assigned this Mar 10, 2025
@serban300 serban300 requested a review from a team as a code owner March 10, 2025 06:59
@serban300 serban300 force-pushed the xcm-decode-cleanup branch 2 times, most recently from bcccb71 to a54d819 Compare March 10, 2025 07:19
@serban300
Deduplicate XCM decoding logic
7b2c164
@serban300
Use decode_with_depth_limit consistently for VersionedXcm
5a0dad1
@serban300
Use decode() for XcmpMessageFormat
00dc22f 
`XcmpMessageFormat` is an enum with no data, so `decode()` only reads a
byte. No need to use `decode_with_depth_limit()`
@serban300
Use decode() for VersionedXcm
2d1cfaa 
We implemented `decode_with_depth_limit()` directly inside
`VersionedXcm::decode()`
@serban300 serban300 force-pushed the xcm-decode-cleanup branch from a54d819 to 2d1cfaa Compare March 10, 2025 07:33
@serban300
Fix unit test
0000f46 
Fix `page_not_modified_when_fragment_does_not_fit()`
bkontur
bkontur reviewed Mar 10, 2025
View reviewed changes
bkontur
bkontur reviewed Mar 10, 2025
View reviewed changes
@serban300 serban300 removed the R0-silent Changes should not be mentioned in any release notes label Mar 10, 2025
@serban300 serban300 changed the title Xcm decoding cleanup Fix XCM decoding inconsistencies Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@bkontur bkontur bkontur approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees

@serban300 serban300

Labels
T6-XCM This PR/Issue is related to XCM.
Projects
Bridges + XCM
Status: In-Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serban300 @bkchr @bkontur @acatangiu