Companion for substrate#11148

[jasl]

Companion for paritytech/substrate#11148

cumulus companion: paritytech/cumulus#1236

[paritytech-processbot]

Waiting for commit status.

[paritytech-processbot]

Merge cancelled due to error. Error: Statuses failed for b5faf5e

[ggwpez]

Where do these values come from?
Not from the bot obviously

[jasl]

Where do these values come from? Not from the bot obviously

just copy paste batch_all (that's made local compiled) I don't know how to trigger the bot

[ggwpez]

/bench runtime polkadot pallet pallet_utility

Not sure if the bot will be able to push to your branch.
You currently still have the diener patch in your Cargo.toml, that needs to be removed for the CI since it contains file paths relative for your machine.

[parity-benchapp]

Benchmark Runtime Polkadot Pallet for branch "companion-11148" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet pallet_utility

Not sure if the bot will be able to push to your branch.
You currently still have the diener patch in your Cargo.toml, that needs to be removed for the CI since it contains file paths relative for your machine. --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Results

error: failed to resolve patches for `https://github.com/paritytech/substrate`

Caused by:
  failed to load source for dependency `beefy-gadget`

Caused by:
  Unable to update /Users/jasl/Workspaces/BlockChain/substrate/client/beefy

Caused by:
  failed to read `/Users/jasl/Workspaces/BlockChain/substrate/client/beefy/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
/bin/sh: 2: 
: not found
/bin/sh: 3: Not: not found
/bin/sh: 1: Cargo.toml: not found
/bin/sh: 4: You: not found

ERROR: Unable to commit file ./runtime/polkadot/src/weights/

[jasl]

/bench runtime polkadot pallet pallet_utility

Not sure if the bot will be able to push to your branch. You currently still have the diener patch in your Cargo.toml, that needs to be removed for the CI since it contains file paths relative for your machine.

Since the original PR merged, I think I can switch to current Substrate master and retry,
this is my first PR about companion, I'm not familiar the process, I'm sorry.

[ggwpez]

No problem @jasl, thanks for your help!
I think the processbot does something like this to update the lockfiles cargo update -p sp-io.

[jasl]

/bench runtime polkadot pallet pallet_utility

[parity-benchapp]

Benchmark Runtime Polkadot Pallet for branch "companion-11148" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet pallet_utility --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Results

error[E0700]: hidden type for `impl Trait` captures lifetime that does not appear in bounds
   --> node/core/backing/src/lib.rs:190:6
    |
190 | ) -> Result<(), Error>
    |      ^^^^^^^^^^^^^^^^^
    |
note: hidden type `impl futures::Future` captures lifetime smaller than the function body
   --> node/core/backing/src/lib.rs:190:6
    |
190 | ) -> Result<(), Error>
    |      ^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0700`.
error: could not compile `polkadot-node-core-backing` due to previous error
error: build failed

ERROR: Unable to commit file ./runtime/polkadot/src/weights/

[jasl]

hmmm looks the bot can't push commit to my branch... @ggwpez any idea?

[jasl]

/bench runtime polkadot pallet pallet_utility

[parity-benchapp]

Benchmark Runtime Polkadot Pallet for branch "companion-11148" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet pallet_utility --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Results

error[E0700]: hidden type for `impl Trait` captures lifetime that does not appear in bounds
   --> node/core/backing/src/lib.rs:190:6
    |
190 | ) -> Result<(), Error>
    |      ^^^^^^^^^^^^^^^^^
    |
note: hidden type `impl futures::Future` captures lifetime smaller than the function body
   --> node/core/backing/src/lib.rs:190:6
    |
190 | ) -> Result<(), Error>
    |      ^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0700`.
error: could not compile `polkadot-node-core-backing` due to previous error
error: build failed

ERROR: Unable to commit file ./runtime/polkadot/src/weights/

[shawntabrizi]

@jasl bot cannot push to forks of the repo unfortunately.

We should just let this merge as is.

[jasl]

@jasl bot cannot push to forks of the repo unfortunately.

We should just let this merge as is.

Okay... just rebased master

[shawntabrizi]

bot merge

[paritytech-processbot]

Error: "Check reviews" status is not passing for paritytech/cumulus#1236

[jasl]

lol, I'll make a companion for Cumulus

[shawntabrizi]

lol, I'll make a companion for Cumulus

I made one for you. See the link i posted in your PR description.

[ggwpez]

I just ran it on ref hardware and your values are close enough 🎉

[shawntabrizi]

bot merge

[paritytech-processbot]

Waiting for commit status.