-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: mark TypeInfo derived impl as automatically_derived #218
Conversation
As per rust-lang/rust#120185, functions with their enclosing impl body marked as `#[automatically_derived]` won't be featured in coverage reports.
@niklasad1 fixed the lifetimes clippy complained about |
It keeps failing for other reasons, ill look it up later and fix everything |
paritytech/parity-scale-codec/pull/653 disallowed duplicate indexes for variants.
@niklasad1 hi again, paritytech/parity-scale-codec#653 disallowed duplicate indexes for variants. I switched the numbers and it should be good to go. I made this PR through the file editor in GitHub so I haven't tested it. |
hey @saiintbrisson again sorry about the CI mess that you are running into The start attribute has been removed and can be replaced with the following patch:
|
I don't think this is as simple. I'll take a look into it a bit later. Does the code really require no_main for this test? |
it might be wrong my bad but I think the test/check is to make sure that it runs/compiles for no-std |
anyway, it's unrelated to this PR let's merge this and fix it another PR |
As per rust-lang/rust#120185, functions with their enclosing impl body marked as
#[automatically_derived]
won't be featured in coverage reports.An example:
