Remove un-needed index field for utility.ItemFailed event

paritytech · Apr 4, 2022 · e5a7a56 · e5a7a56
1 parent 2f3df99
commit e5a7a56
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/frame/utility/src/lib.rs b/frame/utility/src/lib.rs
@@ -118,7 +118,7 @@ pub mod pallet {
 		/// A single item within a Batch of dispatches has completed with no error.
 		ItemCompleted,
 		/// A single item within a Batch of dispatches has completed with error.
-		ItemFailed { index: u32, error: DispatchError },
+		ItemFailed { error: DispatchError },
 		/// A call was dispatched.
 		DispatchedAs { result: DispatchResult },
 	}
@@ -446,7 +446,7 @@ pub mod pallet {
 				weight = weight.saturating_add(extract_actual_weight(&result, &info));
 				if let Err(e) = result {
 					error_indexes.push(index as u32);
-					Self::deposit_event(Event::ItemFailed { index: index as u32, error: e.error });
+					Self::deposit_event(Event::ItemFailed { error: e.error });
 				} else {
 					Self::deposit_event(Event::ItemCompleted);
 				}

diff --git a/frame/utility/src/tests.rs b/frame/utility/src/tests.rs
@@ -625,7 +625,7 @@ fn force_batch_works() {
 			utility::Event::BatchCompletedWithErrors { indexes: vec![1, 2] }.into(),
 		);
 		System::assert_has_event(
-			utility::Event::ItemFailed { index: 1, error: DispatchError::Other("") }.into(),
+			utility::Event::ItemFailed { error: DispatchError::Other("") }.into(),
 		);
 		assert_eq!(Balances::free_balance(1), 0);
 		assert_eq!(Balances::free_balance(2), 20);