This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
nomination-pools: Add era to Unbonded
event
#11749
Labels
J0-enhancement
An additional feature request.
U2-some_time_soon
Issue is worth doing soon.
Z0-trivial
Writing the issue is of the same difficulty as patching the code.
Z6-mentor
An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Comments
So an |
Which other events you have in mind @hirschenberger? It should be events that are era-related. Unbonding has a clear link to eras, because you will be unbnded 28 eras after. For, bonding for example doesn't have any significant semantical relation. |
It was just a question, I had no specific events in mind. I see that |
Unbonded
event
Updated the title to clarify what is meant :) |
hirschenberger
added a commit
to hirschenberger/substrate
that referenced
this issue
Jul 4, 2022
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this issue
Aug 23, 2022
* Add era to `Unbonded` event fixes paritytech#11749 * Fix missing tests * Add comment for `era` field in `Unbonded` struct. Co-authored-by: parity-processbot <>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this issue
Feb 27, 2023
* Add era to `Unbonded` event fixes paritytech#11749 * Fix missing tests * Add comment for `era` field in `Unbonded` struct. Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
J0-enhancement
An additional feature request.
U2-some_time_soon
Issue is worth doing soon.
Z0-trivial
Writing the issue is of the same difficulty as patching the code.
Z6-mentor
An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
In nomination-pools tests that test cases that has Era as part of the case, it is a good idea to add in the
assert_eq!
ofpool_events_since_last_call
the era as part of theeq
.E.g. in the partial_unbond_max_chunks and this assert_eq! could have something like:
The text was updated successfully, but these errors were encountered: