This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix generate_storage_alias!
#11102
Merged
Fix generate_storage_alias!
#11102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
changed the title
generate_storage_alias docsgenerate_storage_alias! docs
kianenigma
approved these changes
Mar 23, 2022
shawntabrizi
changed the title
generate_storage_alias! docsgenerate_storage_alias!
shawntabrizi
added
B0-silent
emostov
approved these changes
Mar 23, 2022
|
bot merge |
paritytech-processbot
bot
deleted the
shawntabrizi-fix-generate-storage-alias
branch
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* add test * fix issues * make order intuitive
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* add test * fix issues * make order intuitive
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* add test * fix issues * make order intuitive
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* add test * fix issues * make order intuitive
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* add test * fix issues * make order intuitive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
generate_storage_alias!macro, where some of the syntaxes had thekeyandhasherin the wrong order in the underlying storage definition.(hasher, key)for the macro definition, which lines up with the order of these same types in the underlying storage type definition.Fortunately, the Rust type system prevents anyone from really messing up here.