This repository was archived by the owner on Nov 15, 2023. It is now read-only.
removes use of sc_client::Client from sc-rpc #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunlanlege
requested review from
andresilva,
Demi-Marie and
tomusdrw
as code owners
|
It looks like @seunlanlege signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
drewstone
reviewed
Feb 26, 2020
seunlanlege
force-pushed
the
seun-remove-client-sc-rpc
branch
from
d63b9ba to
810ad59
Compare
|
same failing ui test as #5030 |
seunlanlege
added
A0-please_review
arkpar
removed
the
A2-insubstantial
arkpar
reviewed
Feb 28, 2020
tomusdrw
reviewed
Mar 2, 2020
seunlanlege
commented
Mar 2, 2020
|
going to mark this as looks good if there are no objections 👀 |
tomusdrw
approved these changes
Mar 4, 2020
client/finality-grandpa/src/lib.rs
Outdated
| LockImportRun, BlockchainEvents, CallExecutor, | ||
| backend::{AuxStore, Backend}, ExecutionStrategy, Finalizer, TransactionFor, | ||
| }; | ||
| use sc_client_api::{LockImportRun, BlockchainEvents, CallExecutor, backend::{AuxStore, Backend}, ExecutionStrategy, Finalizer, TransactionFor, ExecutorProvider}; |
There was a problem hiding this comment.
Looks like a pretty long line
arkpar
approved these changes
Mar 4, 2020
|
🙋🏾 @gnunicorn, this is ready to be merged. |
|
sorry, @seunlanlege the merge order resulted in another conflict. |
|
@gnunicorn fixed. |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 6, 2020
* removes use of sc_client::Client from sc-rpc * remove Client impl from sc-finality-benches * remove client impl from sc-finality-grandpa * read_proof accepts iterator * remove generic Executor param from ExecutorProvider * fix long ass line * code style changes * merge with master Co-authored-by: Arkadiy Paronyan <[email protected]>
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
* removes use of sc_client::Client from sc-rpc * remove Client impl from sc-finality-benches * remove client impl from sc-finality-grandpa * read_proof accepts iterator * remove generic Executor param from ExecutorProvider * fix long ass line * code style changes * merge with master Co-authored-by: Arkadiy Paronyan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #4452