This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if a user puts
schedule_after(0, ...)
, the call will fail because there is a check that the scheduled block must be greater than the current block:This PR simply adds one additional block to any
schedule_after
call. Soschedule_after(0, ...)
will be the block after the current block,schedule_after(1, ...)
will be the block after that, etc... So after this PR, allschedule_after
will happen one block later. This allowsschedule_after
to always pass this check with anyafter
input.This is just a quality of life improvement which should capture the intention of the caller.
cc @xlc