Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more parser error tests to validate top level tokens #373

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

abhikuhikar
Copy link
Contributor

This PR adds more parser error tests to validate the behavior for the top level tokens which was introduced with the PR #369.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@abhikuhikar abhikuhikar assigned dlurton and alancai98 and unassigned dlurton and alancai98 Mar 9, 2021
@abhikuhikar abhikuhikar requested review from alancai98 and dlurton March 9, 2021 21:28
alancai98
alancai98 previously approved these changes Mar 10, 2021
Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a few nits and questions. Otherwise lgtm.

@abhikuhikar abhikuhikar merged commit ce4f7a0 into master Mar 25, 2021
@dlurton dlurton added this to the v0.3.0 milestone Jun 9, 2021
@alancai98 alancai98 deleted the add-parser-error-tests branch September 13, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants