Reduce memory usage of Thread.interrupted() tests #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test also execute significantly faster.
alancai98
requested changes
May 7, 2021
alancai98
approved these changes
May 7, 2021
almann
approved these changes
May 8, 2021
Comment on lines
+48
to
+50
| private val reallyBigNAry = makeBigExprNode(20000000) | ||
| private val bigNAry = makeBigExprNode(10000000) | ||
| private val bigPartiqlAst = makeBigPartiqlAstExpr(10000000) |
There was a problem hiding this comment.
Was the laziness the problem or just a cleanup change?
| } | ||
|
|
||
|
|
||
| class FakeList<T>(override val size: Int, private val item: T) : AbstractList<T>() { |
There was a problem hiding this comment.
A comment would be helpful but this Fake list is just logically a single item expanded N times, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I still don't fully understand, the tests added in PR #398 to the started consuming more than 4gb of RAM after being cherry-picked to the
v0.1.6branch, which would cause the build fail since the JVM was limited to 4gb. I tried increasing the RAM allocated to the JVM but wasn't able to get it to run correctly until 6gb and 7gb is the maximum amount of memory allowed by GitHub actions, which I know we will likely migrate to some day soon. That was cutting it pretty close, so I was felt it was better to reduce memory consumption of the tests in that branch and decided to apply a similar fix tomasterin this PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.