Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItem Partials Render with Previously Found Partial's StyleModifier #356

Closed
bmuenzenmeyer opened this issue Jun 9, 2016 · 1 comment

Comments

@bmuenzenmeyer
Copy link
Member

I am using Pattern Lab Node v2.0.0 onWindows, using thegulp` edition.

Found on a private instance of PL/Node 2.0.0 in prep for WDD 2016.

Expected Behavior

Running blockset.mustache

<section class="blockset {{#vertical}}blockset__vertical{{/vertical}}">
  {{> molecules-block }}
{{#listItems.three}}
  {{> molecules-block }}
{{/listItems.three}}
</section>

should emit blocks with no styleModifier using this pattern

block.mustache

<div class="block {{styleModifier}}">
  {{> atoms-picture }}
  {{> atoms-paragraph }}
</div>

Actual Behavior

Actual output includes the previously found molecules-block with the styleModifier class added.
since this was already parsed

block-hero.mustache

{{> molecules-block:block__hero }}

was already parsed and is polluting this list item parsing.

We have a bunch of unit tests covering pattern parameters, but either regressed or omitted styleModifiers.

@bmuenzenmeyer bmuenzenmeyer added this to the 2.0-alpha milestone Jun 9, 2016
@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Jun 9, 2016

Feels like a regression of #190

[EDIT: or an uncovered case]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant