Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View All is not working on some patterns #549

Closed
vpanugaling opened this issue Nov 1, 2016 · 2 comments
Closed

View All is not working on some patterns #549

vpanugaling opened this issue Nov 1, 2016 · 2 comments
Assignees
Labels

Comments

@vpanugaling
Copy link

vpanugaling commented Nov 1, 2016

I am using Pattern Lab Node v2.5.1 on Windows, with Node v6.9.1, using the Gulp Edition.

Expected Behavior

Click "view all" in the menu should display all patterns for a given category.
e.g. css-utilities > view all (display all css utilities patterns)

Actual Behavior

Click "view all" in the menu is displaying an error =>
ex: css-utilities > view all => Cannot GET /patterns/06-css-utilities/index.html?1477998955055

Most of my patterns does have patternSubtypes or 2nd level menu and I have patterns that are in 1st level menu.

Atoms
  - Buttons
     - Primary
     - Disabled
  - Icons
     - Action Close
Molecules
  - Cards
     - Card Group Header
     - Card Summary
  - Filters
     - Off Positive
Templates
  - Default
  - Nav Active
CSS Utilities
  - Layout Depth
     - Depth
  - Layout Flex
     - Flexbox

If I will try to remove Templates the View All link in CSS Utilities, or if I will have Templates pattern subtypes/ 2nd level menu it will work just fine.

@eliland
Copy link

eliland commented Nov 7, 2016

I had a very similar problem on Gulp edition 1.3.2 and 1.3.3. Seems to have resolved itself with 1.3.4, so you might want to give that a go.

@bmuenzenmeyer
Copy link
Member

I have found and fixed this issue. I want to cover it with unit tests and then push out a release.

bmuenzenmeyer added a commit that referenced this issue Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants