Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make core load any pattern engines more intelligently #610

Closed
5 tasks done
bmuenzenmeyer opened this issue Feb 6, 2017 · 2 comments
Closed
5 tasks done

Make core load any pattern engines more intelligently #610

bmuenzenmeyer opened this issue Feb 6, 2017 · 2 comments
Labels
staged for next release 🏁
Milestone
3.0.0

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Feb 6, 2017 •
edited
Loading

Part of #603

I am going to take this issue, as I believe it also encompasses fixing the merge conflict inside #608

  • Merge Change var to const or let #608
  • Defer load of engines inside module scope until absolutely necessary within build
  • Fix unit tests
  • Pass or alter linting
  • Confirm watches still work
@bmuenzenmeyer bmuenzenmeyer added this to the 3.0.0 milestone Feb 6, 2017
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Feb 6, 2017
Closed
9 tasks
@bmuenzenmeyer bmuenzenmeyer self-assigned this Feb 6, 2017
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Feb 6, 2017
Closed
bmuenzenmeyer added a commit that referenced this issue Feb 7, 2017
@bmuenzenmeyer
WIP deferred engine load!
e6cf3b1 
part of #610
part of the merge of #608

most unit tests working, only a few left - due to me hanging a property off the engine that @geoffp was not doing.
still need to see how it behaves during actual builds
bmuenzenmeyer added a commit that referenced this issue Feb 7, 2017
@bmuenzenmeyer
working against gulp-edition async branch with mustache
ab2244c 
still reporitng quite a few handlebar tests broken

part of #610
bmuenzenmeyer added a commit that referenced this issue Feb 8, 2017
@bmuenzenmeyer
poor object key iteration was looping through all properties, and sub…
7efa976 
…sequently falling through to mustache

only one failing unit test now

part of #610
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Feb 8, 2017
Merged
@bmuenzenmeyer bmuenzenmeyer changed the title Make core load any pattern engines more intelligently, and remove the default Make core load any pattern engines more intelligently Feb 8, 2017
@bmuenzenmeyer
Copy link
Member Author

Descoped #617 from this effort, citing timing.

@bmuenzenmeyer bmuenzenmeyer removed their assignment Feb 8, 2017
@stale
Copy link

stale bot commented Oct 2, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the needs response label Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
staged for next release 🏁
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@bmuenzenmeyer