Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for patternlinks #89

Closed
bmuenzenmeyer opened this issue Feb 5, 2015 · 5 comments
Closed

Support for patternlinks #89

bmuenzenmeyer opened this issue Feb 5, 2015 · 5 comments

Comments

@bmuenzenmeyer
Copy link
Member Author

This is done.

👍

@bmuenzenmeyer bmuenzenmeyer removed their assignment Feb 7, 2015
@bramsmulders
Copy link

It seems that the PHP version also supports pattern linking through data:
pattern-lab/patternlab-php#161
It is undocumented, but it is still a feature alot of people like to see in the node version i guess.

@bmuenzenmeyer
Copy link
Member Author

Hi @bramsmulders

check out .\source\_patterns\01-molecules\05-navigation\00-primary-nav.mustache It has an arbitrary example to showcase this functionality.

<li><a href="{{ link.pages-homepage }}">Home</a></li>

@bramsmulders
Copy link

@bmuenzenmeyer yep, that part of the code is in, and works super awesome. But what @bradfrost & @dmolsen were talking about was doing this in data:

"foo": {
    "url" : "link.pages-about"
}

And read that out like this:

{{# foo }}
<a href="{{ url }}">Foo</a>
{{/ foo }}

And there the {{url}} is parsed and a correct link to the pattern is injected. This is currently not working in the node version of patternlab.

@bmuenzenmeyer
Copy link
Member Author

hi @bramsmulders now I understand. Thanks for clarifying. I've created #171 to handle this

bmuenzenmeyer added a commit that referenced this issue Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants