Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #559
Summary of changes:
We have the same problem as the reporter of #559 but using the handelbars implementation. I think the root of all problems is that almost everywhere the partial name currently is compared with subdir concatenated with '/' and filename.
subdir contains the OS native representation of the relative path, so it will work on linux but not on windows as it will contain backslashes and the rest will be generated with slashes.
I have found the property verbosePartial, which strangely enough is not used anywhere, but has the same value as the things against which pattern_assembler and pattern_registry are testing the partials.
So my solution was to 'normalize' the verbose partial with only forward slashes and use it consequently throughout the sources.
I will create a pull request for the Handelbars implementation (patternengine-node-handlebars), which than makes it work with the default include syntax.
The assumption for the two patches is that the templates are using only forward slashes for the inclusion, which is the only reasonable assumption in my opinion.