Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Contribution Guidelines #690

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Updating Contribution Guidelines #690

merged 1 commit into from
Oct 1, 2017

Conversation

prateekiiest
Copy link
Contributor

Addresses #689 - Issue

Summary of changes:

  • current branching strategy
  • commits should reference issues
  • large enhancements should start with an issue, not a cold PR

@prateekiiest
Copy link
Contributor Author

@bmuenzenmeyer reviews pls

bmuenzenmeyer
bmuenzenmeyer approved these changes Oct 1, 2017
View reviewed changes
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution - I might wordsmith a bit and prep this and be aware that #696 is coming too.

Thanks again!

@bmuenzenmeyer bmuenzenmeyer added the hacktoberfest 🌾 https://hacktoberfest.digitalocean.com label Oct 1, 2017
@bmuenzenmeyer bmuenzenmeyer merged commit c707eee into pattern-lab:dev Oct 1, 2017
@prateekiiest prateekiiest deleted the patch-1 branch October 3, 2017 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

Assignees
No one assigned
Labels
hacktoberfest 🌾 https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prateekiiest @bmuenzenmeyer