Skip to content
This repository was archived by the owner on Feb 7, 2023. It is now read-only.

Add Pattern Tree for Chained Parameters Down a Tree #1

Closed
bmuenzenmeyer opened this issue Nov 6, 2016 · 3 comments
Closed

Add Pattern Tree for Chained Parameters Down a Tree #1

bmuenzenmeyer opened this issue Nov 6, 2016 · 3 comments
Labels
bug / spec incongruity on spec / resolved

Comments

@bmuenzenmeyer
Copy link
Member

pattern-lab/patternlab-node#539
@bmuenzenmeyer
Copy link
Member Author

Confirmed PL Node is off spec, as the left side of the below (PL PHP) is working for pattern group TEST001

image

@bmuenzenmeyer bmuenzenmeyer mentioned this issue Jan 25, 2017
Closed
bmuenzenmeyer added a commit that referenced this issue Feb 2, 2017
@bmuenzenmeyer
adding files for #1
53c39c5
@e2tha-e
Copy link

e2tha-e commented Feb 7, 2017

Referenced by pattern-lab/patternlab-node#250

@bmuenzenmeyer bmuenzenmeyer mentioned this issue May 18, 2017
Closed
bmuenzenmeyer added a commit to pattern-lab/patternlab-node that referenced this issue May 19, 2017
@bmuenzenmeyer
failing unit test demonstrating behavior in #539 and pattern-lab/star…
0496f0d 
…terkit-mustache-acidtest#1
@bmuenzenmeyer bmuenzenmeyer mentioned this issue May 19, 2017
Merged
@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented May 19, 2017 •
edited
Loading

PL Node now returns the following output

image

I attest that this is actually correct, because when rendering only m, there is no data passed to it to trip showMoleculeSubsection to true. That PL PHP renders this constitutes leakage of a downstream pattern (organism) into the rendering of an upstream one (molecule).

@bmuenzenmeyer bmuenzenmeyer mentioned this issue May 19, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug / spec incongruity on spec / resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmuenzenmeyer @e2tha-e