Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial setup of OAuth as in README is broken #9

Closed
tomjonandy opened this issue Oct 15, 2017 · 2 comments
Closed

Initial setup of OAuth as in README is broken #9

tomjonandy opened this issue Oct 15, 2017 · 2 comments
Assignees
@pawelad
Labels
bug Something isn't working
Milestone
v0.10.3

Comments

@tomjonandy
Copy link

When using the python interpreter to set up OAuth as suggested in the README, it fails because:

  • MonzoAPI._token is set in MonzoAPI.__init__ by calling self_get_oauth_token()
  • This calls self._save_token_on_disk() before returning
  • _save _token_on_disk() tries to do token = self._token.copy(), but fails with AttributeError: 'MonzoAPI' object has no attribute '_token' becasue _token isn't set yet because _get_oauth_token() has not yet returned.
@pawelad pawelad self-assigned this Oct 15, 2017
@pawelad pawelad added the bug Something isn't working label Oct 15, 2017
@pawelad pawelad added this to the v0.10.3 milestone Oct 15, 2017
pawelad added a commit that referenced this issue Oct 15, 2017
@pawelad
Fixed saving token file to disk (#9)
92f1399
@pawelad
Copy link
Owner

pawelad commented Oct 15, 2017

You're absolutely right - thanks for the report and sorry for the bug. Should be fixed in just released v0.10.3

@pawelad pawelad closed this as completed Oct 15, 2017
@tomjonandy
Copy link
Author

Great, thanks for the speedy response!

bartonp added a commit to bartonp/pymonzo that referenced this issue Mar 29, 2018
@bartonp
Merge branch 'upstream-master'
99057e4 
* upstream-master:
  Dev version bump
  Prepare release v0.10.3
  Updated CHANGELOG
  Fixed saving token file to disk (pawelad#9)
  Create CODE_OF_CONDUCT.md
  Updated README
  Updated dev requirements file
  Dev version bump
  Prepare release v0.10.2
  Updated tests
  Cleaned up exceptions
  Save 'client_secret' value in JSON token file

# Conflicts:
#	src/pymonzo/monzo_api.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelad pawelad

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.10.3
Development

No branches or pull requests
2 participants
@pawelad @tomjonandy