-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monzo Pots #13
Monzo Pots #13
Conversation
Updated comments for Pots
updated comments to remove typo
Just realised that someone else has also pulled in monzo pots. |
Awesome, thanks for the PR! The CI failure is because of |
Thats no problem I can do all of that.. |
Awesome, just remember to redact your data from the cassete : ) |
Okay, tox is now passing on flake8, will do the endpoint test now. |
@pawelad We should be all good to go now, a -0.1% decrease on coveralls though :( |
src/pymonzo/monzo_api.py
Outdated
def pots(self, refresh=False): | ||
""" | ||
Returns a list of pots owned by the currently authorised user. | ||
Official docs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% a nitpick, but would you mind adding empty lines before Official docs:
and :param refresh:
so it's in the same format as other docstrings? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this looks awesome, thank you!
And sorry it took me almost a week - I was planning to deal with the coverage decrease as well but didn't find the time to do it and it shouldn't block this anyway. I'll try to open a PR for the couple conditional branches ( |
Released in v0.11.0 |
I have added the ability to view the currently authorised user, the ability to see the pots that they have, along with all their data.