goal_amount is not always present #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelad
force-pushed
the
csogilvie-patch-2
branch
from
66fcc86 to
ca03086
Compare
|
Same situation as with #31 - I need to work out the PR workflow - right now it fails because it can't access GitHub secrets, which are needed to decrypt the VCR cassettes... There are some workaround, but I think I want to move away from VCR.py eventually so I'm not sure if it makes sense to pursue them. I ran the test suite locally and everything passed. Thank you for your contribution! |
pawelad
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal_amount is only present for pots when it's enabled on the pot. This sets it as optional, with a default value if not present.