Fix pot deposit handling #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-roberts
commented
Jun 2, 2024
pawelad
force-pushed
the
fix-pot-deposit-handling
branch
from
0d17dac to
fa76f67
Compare
|
Thanks for highlighting this, I'm honestly not sure how I haven't noticed it before. I'll check a couple of things, merge this and try to release a new version soon-ish. |
pawelad
force-pushed
the
fix-pot-deposit-handling
branch
from
fa76f67 to
f5d88ca
Compare
…oints I got the list by looking through `--form` occurrences in https://docs.monzo.com/
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
pawelad
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this issue when trying to make a deposit into a pot.
I found that it was due to "the fact the data was in the query string and not the body".
This is likely an issue across the library, but the change offered in this PR is what I needed for my purposes.