Replace Union[T, NoneType] in all type annotations by Optional[T]. #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses #324. Also, uniformly removes prefix "typing." from type annotations, and replaces "NoneType" by "None", so that the function signatures look more similar to those commonly found in source code.
|
@kernc Unfortunately it looks like we worked in parallel... :-) Interesting to compare the solutions and see many similarities. Please have a look to see if my efforts have useful ideas. Thanks. |
|
Sincere apologies. I went to investigate, and then I had half of it working and couldn't just throw it away. I also realized even existing |
kernc
added a commit
to kernc/pdoc
that referenced
this pull request
Jun 22, 2024
Closes pdoc3#325 Co-authored-by: Hugues Hoppe <[email protected]>
kernc
added a commit
to johann-petrak/pdoc
that referenced
this pull request
Jun 22, 2024
Closes pdoc3#325 Co-authored-by: Hugues Hoppe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #324
Also, uniformly removes prefix "typing." from type annotations, and replaces "NoneType" by "None",
so that the function signatures look more similar to those commonly found in source code.