performance and clarity suggestions from the audit #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent sadness for someone using these equations as a reference for a curve with a different a. It would be better to go through inline at some future point and insert the a values in the equations in the appropriate points, but I haven't done that here.
This matches what we do in the Rust code: we return an invalid encoding error if num * den^2 is non-square.
redshiftzero
force-pushed
the
fixes-audit-3
branch
from
5ea63c7 to
8fe89d1
Compare
hdevalence
reviewed
Aug 17, 2022
hdevalence
reviewed
Aug 17, 2022
hdevalence
reviewed
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses all the remaining suggestions from the audit.
Corresponding spec changes: penumbra-zone/penumbra#1245