Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable mutation-observer scheduler in IE #1476

Closed
wants to merge 1 commit into from

Conversation

davedoran
Copy link

No description provided.

@davedoran davedoran closed this Nov 7, 2017
@benjamingr
Copy link
Collaborator

benjamingr commented Nov 7, 2017

@davedoran hey - everything OK?

@davedoran
Copy link
Author

Yeah - sorry; didn't mean to submit this PR back to the main fork.

@benjamingr
Copy link
Collaborator

@davedoran ok - if I may ask - why was it required on your end?

(You can setScheduler by the way and avoid changing the source code)

@davedoran
Copy link
Author

I develop a large application that is migrating from jQuery to BlueBird. We're noticing that - on IE11 - the MutationObserver occasionally fails to trigger when it should. The result is (rarely) a serious performance impact on IE. We have seen delays in the range of minutes where the application is blocked waiting for the callback.

Unfortunately, I don't have a reliable testcase outside of my application (hence - not submitting this patch) but falling back to setTimeout on IE sidesteps the issue.

Thanks for the hint re: setScheduler. That will be very useful.

@benjamingr
Copy link
Collaborator

Thanks for the update, we'll look into it.

@davedoran
Copy link
Author

Cool - thanks. I suspect we're hitting the same issue discussed here:

#1161
https://github.com/lowkay/MutationObserverSchedulerBug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants