Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added compatibility with label_format #999

Merged
merged 2 commits into from
Jan 17, 2015
Merged

Conversation

mrcmorales
Copy link
Contributor

added compatibility with feature #12050 [Form] Added "label_format" option (webmozart)

symfony/symfony@832c78f

added compatibility with label_format
@phiamo
Copy link
Owner

phiamo commented Jan 12, 2015

@mrcmorales can you add documentation for this please

@mrcmorales
Copy link
Contributor Author

@phiamo I can, but this feature is from symfony, then this doc would be in symfony doc.

This doc are done in symfony doc but not merge yet.

symfony/symfony-docs#4412

@phiamo
Copy link
Owner

phiamo commented Jan 12, 2015

ah, did this come with a recent version of symfony? do we need a version constraint, i assume no, you tried to come over this as far as i understand the PR. if thats true i am fine merging this

@mrcmorales
Copy link
Contributor Author

@isometriks
Copy link
Collaborator

Will we need an and label_format is defined? as well for previous versions of Symfony since this variable won't be defined?

@phiamo
Copy link
Owner

phiamo commented Jan 12, 2015

Not sure if the is empty does the trick, but yes thats what i mesnt too. Can smbd confirm this?

@mrcmorales
Copy link
Contributor Author

@phiamo to be secure, I can add label_format is defined condition.

@mrcmorales
Copy link
Contributor Author

@phiamo I tested with sf 2.3 and is necessary control if var is defined, I updated PR.

@phiamo
Copy link
Owner

phiamo commented Jan 17, 2015

thanks a lot

phiamo added a commit that referenced this pull request Jan 17, 2015
added compatibility with label_format
@phiamo phiamo merged commit e0bd518 into phiamo:master Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants