-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added compatibility with label_format #999
Conversation
added compatibility with label_format
@mrcmorales can you add documentation for this please |
@phiamo I can, but this feature is from symfony, then this doc would be in symfony doc. This doc are done in symfony doc but not merge yet. |
ah, did this come with a recent version of symfony? do we need a version constraint, i assume no, you tried to come over this as far as i understand the PR. if thats true i am fine merging this |
This feature was added in 2.6 http://symfony.com/blog/a-week-of-symfony-405-29-september-05-october-2014 |
Will we need an |
Not sure if the is empty does the trick, but yes thats what i mesnt too. Can smbd confirm this? |
@phiamo to be secure, I can add label_format is defined condition. |
@phiamo I tested with sf 2.3 and is necessary control if var is defined, I updated PR. |
thanks a lot |
added compatibility with label_format
added compatibility with feature #12050 [Form] Added "label_format" option (webmozart)
symfony/symfony@832c78f