property-hooks.xml Replace 'all' with 'non-static', as not all + typos #4116
Conversation
The word `all` seems to deceive the reader a little :) How about adding some specifics about which properties are allowed to declare hooks for?
mmalferov
changed the title
language/oop5/property-hooks.xml
Outdated
| @@ -25,7 +25,7 @@ | |||
| </listitem> | |||
| </orderedlist> | |||
| <simpara> | |||
| There are two hooks available on all properties: <literal>get</literal> and <literal>set</literal>. | |||
| There are two hooks available on typed or untyped non-static properties: <literal>get</literal> and <literal>set</literal>. | |||
There was a problem hiding this comment.
Agreed on clarifying non-static. But "typed or untyped" reduces to all, so is redundant.
There was a problem hiding this comment.
By saying "typed or untyped", I meant that hooks can work with both typed and untyped properties, or rather, that it is not necessary to type a property ;) As opposed to, for example, read-only properties that work only with typed properties
There was a problem hiding this comment.
I have indicated the availability of hooks for both typed and untyped properties in a separate sentence. It seems that now it doesn't look redundant and informs the reader that hooks will work with both typed properties and untyped ones.
|
Looks good aside from those comments, and the need to rebase. Thanks. |
Specify that hooks are available for both typed and untyped properties
|
Looks good now. Thanks! |
The word
allseems to deceive the reader a little :)How about adding some specifics about which properties are allowed to declare hooks for?